Issue using stations for setup

[SorooshMani-NOAA]

@jreniel, I've been mostly using older version of PySCHISM (before ModelConfig API was introduced). I recently started using the later version and I noticed an issue with stations.

I create a Stations object and pass it to the coldstart method of ModelConfig. Then when I write the config to disk, using the coldstart object's write method, I don't see output for iout_sta and nspool_sta in the param file.

I tried to look at the code to see if I'm using it wrong, but it seems that in the definition of SCHOUT object nspool_sta needs to be passed

pyschism/pyschism/param/schout.py

Lines 104 to 124 in ec00dff

	class SCHOUT(
	metaclass=SchoutMeta
	):
	""" Provides error checking implementation for SCHOUT group """
	def __init__(
	self,
	nhot_write: int = None,
	nspool_sta: int = None,
	**outputs
	):
	"""
	nhot_write:
	- if -1 will write last timestep (default)
	- if None it will be disabled.
	- if int interpreted as iteration
	- if timedelta it will be rounded to the nearest iteration
	"""
	self.nhot_write = nhot_write
	self.nspool_sta = nspool_sta

otherwise it won't write the parameters to param.nml:

pyschism/pyschism/param/schout.py

Lines 138 to 149 in ec00dff

	if self.nspool_sta is not None:
	nspool_sta = self.nspool_sta
	if isinstance(nspool_sta, timedelta):
	nspool_sta = int(round(nspool_sta.total_seconds() / self.dt))
	if isinstance(nspool_sta, float):
	nspool_sta = int(
	round(timedelta(hours=nspool_sta) / self.dt))
	if isinstance(nspool_sta, (int, float)):
	if nspool_sta <= 0:
	raise ValueError("nspool_sta must be positive.")
	schout.append(f" iout_sta={self.iout_sta}")
	schout.append(f" nspool_sta={nspool_sta}")

And it seems that during the creation of SCHOUT object within Param object, nspool_sta is not passed:

pyschism/pyschism/param/param.py

Line 40 in ec00dff

self.schout = SCHOUT()

I don't see anywhere else where nspool_sta is getting updated. So my guess is that this is a bug.

Please let me know if I'm missing anything. Thanks!