New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

more flexible inputs #238

Open

CPernet opened this issue Feb 6, 2025 · 0 comments

Assignees

Labels

Contributor

CPernet commented Feb 6, 2025 •

edited

Loading

changes in pop_importbids
https://github.com/sccn/EEG-BIDS/blob/allows-subject-and-run-names-rather-than-integers/pop_importbids.m

takes {'sub-XXX','sub-XXX'} or {'XXX','XXX'} as input rather than integers -- but integers still work
(changes here https://github.com/sccn/EEG-BIDS/blob/allows-subject-and-run-names-rather-than-integers/pop_importbids.m#L243)

takes {'XXX','XXX'} for run (because of '1' vs '01') -- but integers still work
(changes here https://github.com/sccn/EEG-BIDS/blob/allows-subject-and-run-names-rather-than-integers/pop_importbids.m#L844 ; you may not like that one, introducing a more recent extract function)

-- still issue with finputcheck as now takes only cells even if integer can work (and we want to keep things backcompatibe)

CPernet added the enhancement label

CPernet assigned arnodelorme

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment