diff --git a/.github/common_edge_cases.md b/.github/common_edge_cases.md index 63bdcbd288c..35d1063c867 100644 --- a/.github/common_edge_cases.md +++ b/.github/common_edge_cases.md @@ -9,6 +9,7 @@ Will this also work if - The user is logged out and views a public dataset or annotation - User uses dark mode / light mode - There is no local datastore/tracingstore module (Compare [instructions to test this locally](https://github.com/scalableminds/webknossos/wiki/Set-up-a-standalone-datastore-locally)) + - An annotation is opened by multiple users at the same time Consider SQL pitfalls: - `x IN ()` statements must never called with empty list diff --git a/frontend/javascripts/admin/dataset/composition_wizard/04_configure_new_dataset.tsx b/frontend/javascripts/admin/dataset/composition_wizard/04_configure_new_dataset.tsx index 4d9698de948..186937b1dab 100644 --- a/frontend/javascripts/admin/dataset/composition_wizard/04_configure_new_dataset.tsx +++ b/frontend/javascripts/admin/dataset/composition_wizard/04_configure_new_dataset.tsx @@ -32,7 +32,7 @@ import type { APIDataLayer, APIDataset, APITeam, LayerLink } from "types/api_typ import { syncValidator } from "types/validation"; import { WkDevFlags } from "viewer/api/wk_dev"; import type { Vector3 } from "viewer/constants"; -import { getReadableURLPart } from "viewer/model/accessors/dataset_accessor"; +import { getReadableURLPart, getViewDatasetURL } from "viewer/model/accessors/dataset_accessor"; import { flatToNestedMatrix } from "viewer/model/accessors/dataset_layer_transformation_accessor"; import { checkLandmarksForThinPlateSpline } from "viewer/model/helpers/transformation_helpers"; import type { WizardComponentProps } from "./common"; @@ -372,7 +372,7 @@ function LinkedLayerForm({ info="This is the layer which will be linked into the new dataset." > diff --git a/frontend/javascripts/admin/dataset/dataset_add_view.tsx b/frontend/javascripts/admin/dataset/dataset_add_view.tsx index fce8a59045a..7ec76859414 100644 --- a/frontend/javascripts/admin/dataset/dataset_add_view.tsx +++ b/frontend/javascripts/admin/dataset/dataset_add_view.tsx @@ -9,7 +9,7 @@ import { useWkSelector } from "libs/react_hooks"; import React, { useState } from "react"; import { useNavigate } from "react-router-dom"; import type { APIDataStore } from "types/api_types"; -import { getReadableURLPart } from "viewer/model/accessors/dataset_accessor"; +import { getReadableURLPart, getViewDatasetURL } from "viewer/model/accessors/dataset_accessor"; import DatasetAddComposeView from "./dataset_add_compose_view"; const { Content, Sider } = Layout; @@ -306,9 +306,7 @@ const getPostUploadModal = (