Fix line and path separators in test #23534
Draft
+31
−60
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23458
Splitting on NL leaves the CR if present. Just use
linesIterator
.Introduce a template method for rendering paths. The test reporter replaces windows convention when run on windows, so that check files are correct;
FileDiff.matches
currently accounts for comparing lines of text when run on windows.Previously, a
TestReporter
with empty console output would contribute a NL because"".split("\n")
is not empty. (There is a test reporter per compilation group.)