Closed
Description
I think it may make the most sense to rename MultiDict
to SetMultiMap
, and potentially make MultiMap
into a generic trait.
- It helps remove the @Deprecation warning if renamed back to
MultiMap
- "MultiMap" is a more universally used terminology for this type of collection. (e.g. Guava has
ArrayListMultimap
,ListMultimap
,SetMultimap
, and etc; C++ STL isstd::multimap
; Rust isMultiMap
, Apache Commons isMultiMap
, etc) - The existing name also does support or convey the collection type of the key's values. (e.g. it currently implements
Set
, but there is no way to extend it to use anArray
,Vector
orList
instead) - The code still uses
MultiMap
in various locations (like in the hashcode!), and theCC[_]
isMapFactory
(e.g. notDictFactory
) - There are no other Dictionary terms in any of the Scala collections. It's
Map
for any scala code, only the java converters have the mention of a dictionary.MultiDict
isn't scala idiomatic.
Metadata
Metadata
Assignees
Labels
No labels