Skip to content

Commit 29724e9

Browse files
authored
Merge pull request #825 from scala-js/fix-returntype-serialnumber-webnfc
fix: `NDEFReadingEventInit.serialNumber` returns a string
2 parents cccf225 + 5170f89 commit 29724e9

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

api-reports/2_12.txt

+1-1
Original file line numberDiff line numberDiff line change
@@ -16689,7 +16689,7 @@ NDEFReadingEventInit[JT] var cancelable: js.UndefOr[Boolean]
1668916689
NDEFReadingEventInit[JT] var composed: js.UndefOr[Boolean]
1669016690
NDEFReadingEventInit[JT] var message: NDEFRecordInit
1669116691
NDEFReadingEventInit[JT] var scoped: js.UndefOr[Boolean]
16692-
NDEFReadingEventInit[JT] var serialNumber: js.UndefOr[AbortSignal]
16692+
NDEFReadingEventInit[JT] var serialNumber: js.UndefOr[String]
1669316693
NDEFRecord[JC] def data: js.typedarray.DataView
1669416694
NDEFRecord[JC] def encoding: js.UndefOr[String]
1669516695
NDEFRecord[JC] def id: js.UndefOr[String]

api-reports/2_13.txt

+1-1
Original file line numberDiff line numberDiff line change
@@ -16689,7 +16689,7 @@ NDEFReadingEventInit[JT] var cancelable: js.UndefOr[Boolean]
1668916689
NDEFReadingEventInit[JT] var composed: js.UndefOr[Boolean]
1669016690
NDEFReadingEventInit[JT] var message: NDEFRecordInit
1669116691
NDEFReadingEventInit[JT] var scoped: js.UndefOr[Boolean]
16692-
NDEFReadingEventInit[JT] var serialNumber: js.UndefOr[AbortSignal]
16692+
NDEFReadingEventInit[JT] var serialNumber: js.UndefOr[String]
1669316693
NDEFRecord[JC] def data: js.typedarray.DataView
1669416694
NDEFRecord[JC] def encoding: js.UndefOr[String]
1669516695
NDEFRecord[JC] def id: js.UndefOr[String]

dom/src/main/scala/org/scalajs/dom/NDEFReadingEventInit.scala

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ trait NDEFReadingEventInit extends EventInit {
1515
/** A string with the name of the event. It is case-sensitive and browsers always set it to reading. Default is "" an
1616
* empty string
1717
*/
18-
var serialNumber: js.UndefOr[AbortSignal] = js.undefined
18+
var serialNumber: js.UndefOr[String] = js.undefined
1919

2020
/** An object that, in addition of the properties defined in Event(), can have the following properties: serialNumber;
2121
* message

0 commit comments

Comments
 (0)