This repository has been archived by the owner on Oct 8, 2021. It is now read-only.
Fix bug when making an adjacency_matrix from a SimpleGraph with self-loops in Julia 1.7
#1595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…loops in Julia 1.7
|
Note that when I run the tests locally using Julia 1.7, there are other tests that fail, so it looks like the package needs some other updates for Julia 1.7. |
|
Would be great if these could be fixed soon. I'm trying to ensure improvements are stable across Julia versions for #1596 and these errors make it pretty difficult. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug when making an
adjacency_matrixfrom aSimpleGraphwith self-loops in Julia 1.7As described in #1594, Julia 1.7 adds a stricter check on the
SparseMatrixCSCconstructor for consistency about the number of nonzero elements input. The number of nonzero elements are currently being overcounted in the case ofSimpleGraphwith self-loops, this should fix that overcounting.Fixes #1594.