Likely Bugs in the "Using the O’Neil (2019) Observation-based Priors" Tutorial

[gabeweible]

Describe the bug

1. The ObsPrior class in the source code of priors.py appears to want the required arguments ordered as: epochs, ra_err, dec_err, mtot, but the tutorial provides these arguments in the order: ra_err, dec_err, epochs, mtot (in the tutorial, the last of these is the system_mass variable).
2. The astropy.table.column.Column variable for the error in relative declination, dec_err, should be assigned the value: mySystem.data_table["quant2_err"], but the tutorial assigns: mySystem.data_table["quant1_err"] (i.e., the same astropy.table.column.Column for relative right ascension as assigned to ra_err in the tutorial).

To Reproduce
Go to: Using the O’Neil (2019) Observation-based Priors, Priors to compare argument ordering and see the dec_err assignment in the tutorial.

Screenshots

Desktop (please complete the following information):

• orbitize! Version 3.1.0

[gabrielastro]

Small note: there is currently an error with TypeError: a bytes-like object is required, not 'str' about display.Image("eift_hd206893.png") and higher up: "We begin but reading in" → "We begin by reading in" :). And while at it, you could add the link to O'Neil et al. (2019) for convenience: https://ui.adsabs.harvard.edu/abs/2019AJ....158....4O (and of course https://ui.adsabs.harvard.edu/abs/2023AJ....166...48D for Do Ó et al. 2023). I just noticed too that some places in the code write O'Neil et al. (2018) instead of 2019 based on the arXiv appearance.