Ducktape modernize #87
Conversation
KrisMagjistari
force-pushed
the
ducktape-modernize
branch
from
7b6f1a1 to
7a589ea
Compare
KrisMagjistari
force-pushed
the
ducktape-modernize
branch
2 times, most recently
from
eae2a4f to
4d9fa93
Compare
| ducktape::apache::shield_vhost::enabled: true | ||
| ducktape::apache::shield_vhost::ensure: 'present' | ||
| ducktape::apache::shield_vhost::port: 80 | ||
| #ducktape::apache::shield_vhost::docroot: "%{lookup('apache::docroot')}" |
There was a problem hiding this comment.
Is this correct?
There was a problem hiding this comment.
I think no since apache::docroot might be defined on code instead of hiera
There was a problem hiding this comment.
Well for now for these particular cases, when the value of a parameter is a puppet resource/class param, I have left their default values inside the puppet code.
There was a problem hiding this comment.
Déjalo en la clase y crea un ticket en team para ver si podemos mejorar o simplificar la clase shield_vhost.
| Boolean $enabled, | ||
| Hash $instance_defaults = { | ||
| bind => $::redis::bind, | ||
| port => $::redis::port, |
There was a problem hiding this comment.
How can you represent these variables on the yaml file?
Im guessing
ducktape::redis::external::munin_node_plugin::instance_defaults
bind: lookup(...)
port: lookup(...)There was a problem hiding this comment.
Your guess is half right, but again you can't rely on other modules defining it's params on hiera
KrisMagjistari
force-pushed
the
ducktape-modernize
branch
6 times, most recently
from
9cb7656 to
709c2c3
Compare
KrisMagjistari
force-pushed
the
ducktape-modernize
branch
from
709c2c3 to
d5dabaa
Compare
KrisMagjistari
force-pushed
the
ducktape-modernize
branch
from
d5dabaa to
61d39e6
Compare
No description provided.