From 53cafa4bf0eb37c5ff7240b9955860739558b3ea Mon Sep 17 00:00:00 2001 From: Sathia Date: Sat, 19 Oct 2019 12:11:43 +0530 Subject: [PATCH] fix(#12): contriubtion guidelines - new package installation instruction --- CONTRIBUTING.md | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 4bbb7bf..fd96db7 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -34,6 +34,13 @@ Every PR/commit on this repository will be run through a build pipeline to ensur ### Your first contribution Unsure where to begin contributing to GHCL? You can start by looking through these +### Adding any new package +If you are adding any external package on project, please make you use `Pipenv’s Dependency Resolution Approach` + +eg: if you want to add redis package. Follow below steps +`pipenv install redis` +By doing this way, it'll update the Pipfile and Pipfile.lock. + * [good first issue](https://github.com/javatarz/github-contribution-leaderboard/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22+sort%3Acomments-desc) - issues which should only require a few lines of code, and a test or two * [help-wanted issues](https://github.com/javatarz/github-contribution-leaderboard/issues?q=is%3Aopen+is%3Aissue+label%3A%22help+wanted%22+sort%3Acomments-desc) - issues which should be a bit more involved than beginner issues