Skip to content

Commit c3e55c7

Browse files
committedMay 4, 2020
Improve MakeMaker incompatibility message
Previous message lead to some confusion when people didn't get why the minimal version was much lower than the message suggested, as downgrade also works.
1 parent 5db54f2 commit c3e55c7

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed
 

‎Makefile.PL

+3-2
Original file line numberDiff line numberDiff line change
@@ -480,8 +480,9 @@ if ($EMMV > 7.10 && $EMMV < 7.20) {
480480
# Fix another issue if as-needed is not supported
481481
# https://github.com/sass/perl-libsass/issues/26
482482
unless (`ld --help` =~ /--no-as-needed/) {
483-
warn "Your current ExtUtils::MakeMaker has a bug\n";
484-
die "You need to upgrade ExtUtils::MakeMaker to 7.20+\n";
483+
die "Your current ExtUtils::MakeMaker $EMMV has a known bug!\n" .
484+
"Bug is present with MakeMaker 7.10 and fixed with 7.20.\n" .
485+
"Please up or downgrade ExtUtils::MakeMaker accordingly!\n";
485486
}
486487
if (exists $compiler_flags{'dynamic_lib'}) {
487488
my $dynlibs = $compiler_flags{'dynamic_lib'};

0 commit comments

Comments
 (0)
Please sign in to comment.