Properly deprivatize names that start with multiple underscores

Author: nex3

lib/src/migrators/module.dart

@@ -6,6 +6,7 @@
 
 import 'package:args/args.dart';
 import 'package:collection/collection.dart';
+import 'package:charcode/charcode.dart';
 import 'package:path/path.dart' as p;
 import 'package:sass_api/sass_api.dart';
 import 'package:source_span/source_span.dart';
@@ -191,6 +192,9 @@ class _ModuleMigrationVisitor extends MigrationVisitor {
           "Can't access _configuredVariables when not visiting a dependency."));
   Set<MemberDeclaration<VariableDeclaration>>? __configuredVariables;
 
+  /// The number of variables that have been generated from whole cloth.
+  var _generatedVariables = 0;
+
   /// A mapping between member declarations and references.
   ///
   /// This performs an initial pass to determine how a declaration seen in the
@@ -354,9 +358,9 @@ class _ModuleMigrationVisitor extends MigrationVisitor {
     var name = declaration.name;
     if (_isPrivate(name) &&
         references.referencedOutsideDeclaringStylesheet(declaration)) {
-      // Remove leading `-` since private members can't be accessed outside
-      // the module they're declared in.
-      name = name.substring(1);
+      // Private members can't be accessed outside the module they're declared
+      // in.
+      name = _privateToPublic(name);
     }
     name = _unprefix(name);
     if (name != declaration.name) {
@@ -372,6 +376,20 @@ class _ModuleMigrationVisitor extends MigrationVisitor {
     return identifier.startsWith('-') || identifier.startsWith('_');
   }
 
+  /// Converts a private identifier to a public one.
+  String _privateToPublic(String identifier) {
+    assert(_isPrivate(identifier));
+    for (var i = 0; i < identifier.length; i++) {
+      var char = identifier.codeUnitAt(i);
+      if (char != $dash && char != $underscore) {
+        return identifier.substring(i);
+      }
+    }
+
+    _generatedVariables++;
+    return 'var${_generatedVariables}';
+  }
+
   /// Returns whether the member named [name] should be forwarded in the
   /// entrypoint.
   ///
@@ -1083,7 +1101,7 @@ class _ModuleMigrationVisitor extends MigrationVisitor {
         if (declaration is ImportOnlyMemberDeclaration) {
           name = name.substring(declaration.importOnlyPrefix.length);
         }
-        if (_isPrivate(name)) name = name.substring(1);
+        if (_isPrivate(name)) name = _privateToPublic(name);
         name = _unprefix(name);
         if (subprefix.isNotEmpty) name = '$subprefix$name';
         if (declaration.member is VariableDeclaration) name = '\$$name';
@@ -1236,7 +1254,7 @@ class _ModuleMigrationVisitor extends MigrationVisitor {
   /// Otherwise, returns [name] unaltered.
   String _unprefix(String name) {
     var isPrivate = _isPrivate(name);
-    var unprivateName = isPrivate ? name.substring(1) : name;
+    var unprivateName = isPrivate ? _privateToPublic(name) : name;
     var prefix = _prefixFor(unprivateName);
     if (prefix == null) return name;
     return (isPrivate ? '-' : '') + unprivateName.substring(prefix.length);

test/migrators/module/scope/pseudoprivate.hrx

@@ -0,0 +1,19 @@
+<==> arguments
+--migrate-deps
+<==> input/entrypoint.scss
+@import "library";
+a {
+  color: $-var;
+}
+
+<==> input/_library.scss
+$-var: red;
+
+<==> output/entrypoint.scss
+@use "library";
+a {
+  color: library.$var;
+}
+
+<==> output/_library.scss
+$var: red;

test/migrators/module/scope/pseudoprivate/dash.hrx

@@ -0,0 +1,19 @@
+<==> arguments
+--migrate-deps
+<==> input/entrypoint.scss
+@import "library";
+a {
+  color: $---;
+}
+
+<==> input/_library.scss
+$---: red;
+
+<==> output/entrypoint.scss
+@use "library";
+a {
+  color: library.$var1;
+}
+
+<==> output/_library.scss
+$var1: red;

test/migrators/module/scope/pseudoprivate/dashes_only.hrx

@@ -0,0 +1,19 @@
+<==> arguments
+--migrate-deps
+<==> input/entrypoint.scss
+@import "library";
+a {
+  color: $--var;
+}
+
+<==> input/_library.scss
+$--var: red;
+
+<==> output/entrypoint.scss
+@use "library";
+a {
+  color: library.$var;
+}
+
+<==> output/_library.scss
+$var: red;

test/migrators/module/scope/pseudoprivate/double_dash.hrx

@@ -0,0 +1,21 @@
+<==> arguments
+--migrate-deps
+<==> input/entrypoint.scss
+@import "library";
+a {
+  color: $middle;
+}
+
+<==> input/_library.scss
+$-upstream: red;
+$middle: $-upstream;
+
+<==> output/entrypoint.scss
+@use "library";
+a {
+  color: library.$middle;
+}
+
+<==> output/_library.scss
+$-upstream: red;
+$middle: $-upstream;

test/migrators/module/scope/pseudoprivate/indirect.hrx

@@ -0,0 +1,19 @@
+<==> arguments
+--migrate-deps
+<==> input/entrypoint.scss
+@import "library";
+a {
+  color: $_var;
+}
+
+<==> input/_library.scss
+$_var: red;
+
+<==> output/entrypoint.scss
+@use "library";
+a {
+  color: library.$var;
+}
+
+<==> output/_library.scss
+$var: red;