Flask february release #7
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
But allow others to be able to use stormpath with python3
Add error for facebook
Also, sender for user_deleted signal is None (instead of User object). When running on Python 3, when blinker iterates through all receivers listening for sender (receivers_for() method on Signal), it tries to get hashable_identity for the sender. To do that, it checks if sender has '__func__' attribute. This calls _ensure_data() on User object that we have just deleted (so it doesn't exist any more).
Blinker and Python3
- importing stormpath_config from a local repository (not available through pip) - commented out MoveApiKeyToClientAPIKeyStrategy (not yet implemented in stormpath_config) - fixed field mapping in app.config dict object - skipped all the tests that are broken due to partly implemented StormpathSettings class
'moved init settings to manager because we need the manager settings' (c73eb55) Updated test_settings.py.
Conflicts: requirements.txt setup.py
'removed redundant settings -> defined in default config' (e7e1ad2) Commented out STORMPATH_BASE_TEMPLATE config setting.
…mented the rest Conflicts: flask_stormpath/__init__.py Commented out StormpathSettigns.__contains__, current mapping breaks the code.
Conflicts: flask_stormpath/views.py Removed field mapping and replaced with Resource.to_camel_case().
ValidateClientConfigStrategy makes sure that apiKey id and secret are always present.
…_api_keys Cleanup unit tests.
…r_page Filter form fields before passing to User.create()
- moved accept header and request json logic to request_processors.py - return form.hidden_tag in login template (and removed form.csrf_token) (hidden_tag checks for every hidden field, not just csrf fields) - CSRFProtection object is now passed to and activated in StormpathManager init method - csrf is now manually checked before every request
- removed visible field attribute - removed organization field
- also moved all config.setdefaults to a setdefault method - added create_social_directory
>> moved create_social_directory to helpers >> now creating social directories on main setup
MoveStormpathSettingsToStormpathConfigStrategy name.
Conflicts: flask_stormpath/views.py
…into xy_backup Conflicts: flask_stormpath/__init__.py flask_stormpath/context_processors.py flask_stormpath/forms.py flask_stormpath/models.py flask_stormpath/views.py setup.py tests/helpers.py tests/test_context_processors.py tests/test_decorators.py tests/test_settings.py tests/test_views.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.