Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude patches dir from auto-formatting #322

Closed
m273d15 opened this issue Nov 26, 2018 · 4 comments
Closed

Exclude patches dir from auto-formatting #322

m273d15 opened this issue Nov 26, 2018 · 4 comments
Assignees

Comments

@m273d15
Copy link
Contributor

m273d15 commented Nov 26, 2018

As @fzieris mentioned in #313

The files in the "patches" folder were always excluded from any auto-format commits. Those are "original" pieces of other projects' code with minor amendments. Auto-formatting these makes it way harder to see the actual "patch".

The following steps are required:

  • Verify whether other directories are affected
  • Adjust Travis CI formatting
  • Adjust example git hook
  • Undo formatting
@m273d15 m273d15 self-assigned this Nov 26, 2018
@fzieris
Copy link
Member

fzieris commented Nov 26, 2018

I never actually needed to reconstruct the original patch, though. Instead of engineering a work-around for not-auto-formatting some files, it might be better to think about the "patches" files themselves:

  • Do current versions of our dependencies still need to be patched?
  • Can we entice the original projects to incorporate our patches?
  • Are there other options for Saros to get the desired functionality with unpatched dependencies, e.g. through more "common" ways such as sub-classing or wrapping?

@m273d15
Copy link
Contributor Author

m273d15 commented Nov 26, 2018

This task will be part of the upcoming dependency updates

I found an entry in the patches/smack_patches_readme.txt that implies that the sources in the patches directory were always part of the auto-formatting:

If you delete the patches then you have to reapply them if they are not already fixed
in the updated SMACK version.

As this mostly not work automatically because the file will get auto formated if you doing
changes the following steps are recommended.

@fzieris
Copy link
Member

fzieris commented Nov 26, 2018

Ah, I see, line 27: "Format them to apply our format rules." My bad.

@m273d15 m273d15 closed this as completed Nov 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants