Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating SmbdContainerImage and ServiceAccountName via environment does not change the share's deployment's image #219

Open
ibotty opened this issue Jun 15, 2022 · 2 comments

Comments

@ibotty
Copy link
Contributor

ibotty commented Jun 15, 2022

This is on version v0.2.

> oc logs -n samba-operator-system deploy/samba-operator-controller-manager
2022-06-15T09:33:03.716Z        INFO    setup   loaded configuration successfully       {"config": {"SmbdContainerImage":"quay.io/samba.org/samba-server:v0.2","SmbdMetricsContainerImage":"qu
ay.io/samba.org/samba-metrics:v0.2","SvcWatchContainerImage":"quay.io/samba.org/svcwatch:v0.2","SmbdContainerName":"samba","WinbindContainerName":"wb","WorkingNamespace":"samba-operator-syst
em","SambaDebugLevel":"","StatePVCSize":"1Gi","ClusterSupport":"","SmbServicePort":445,"SmbdPort":445,"ServiceAccountName":"samba","MetricsExporterMode":"disabled","PodName":"samba-operator-
controller-manager-7486c6dcf5-zq7w7","PodNamespace":"samba-operator-system","PodIP":"172.20.11.77"}}
[...]
2022-06-15T09:33:26.516Z        INFO    controllers.SmbShare    Updating state for SmbShare  {"smbshare": "namespace/my-share", "SmbShare.Namespace": "namespace", "SmbShare.Name": "myshare", "Smb
Share.UID": "f69ba631-de0b-4856-b3fb-b0cb9f2a4ca1"}
2022-06-15T09:33:31.718Z        INFO    controllers.SmbShare    Done updating SmbShare resources      {"smbshare": "namespace/my-share"}

But:

> oc get po -n namespace myshare | grep -E '(serviceAccountName|image):'
    image: quay.io/samba.org/samba-server:latest
  serviceAccountName: default
    image: quay.io/samba.org/samba-server:latest
@phlogistonjohn
Copy link
Collaborator

Odd. Is it possible that the pods with these images were created before you were using the v0.2 operator image?

If yes, that's expected, the operator doesn't yet have the ability to "upgrade" running pods. If no, I'll ask for more info such as a full yaml dump of the operator deployment and the pods/deployments exhibiting the behavior. Thanks!

@ibotty
Copy link
Contributor Author

ibotty commented Jun 15, 2022

Yes, they were created before using the v0.2 operator image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants