You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is definitely the messiest module, although to some extent that's because it's the most complex. It would be nice if it was a little more pythonic - I'd like it to read more like pseudocode. There are also some rather long lines, and fairly long methods. Could probably also do with factoring out the isinstance stuff which lets you pass datetimes or hours and values or lists of values etc.
The text was updated successfully, but these errors were encountered:
Before refactoring, it would be worth running it through pylint/flake8. Python code shouldn't use tabs, and there are some other whitespace issues like spaces after #s that it would make sense to deal with first, in one go.
This is definitely the messiest module, although to some extent that's because it's the most complex. It would be nice if it was a little more pythonic - I'd like it to read more like pseudocode. There are also some rather long lines, and fairly long methods. Could probably also do with factoring out the isinstance stuff which lets you pass datetimes or hours and values or lists of values etc.
The text was updated successfully, but these errors were encountered: