CORS docs wrong - Service needed

[tennox]

Problem

Took me hours of debugging to figure out the example on salvo_cors docs is wrong:

let router = Router::new().hoop(cors_handler).get(hello);

the server responds with a 405 Method Not Allowed to a preflight request:

❯ http OPTIONS http://localhost:5800
HTTP/1.1 405 Method Not Allowed

Solution

The only way it works is if the cors handler is added to a service (like I found in examples/cors on this repo):

let service = Service::new(
        Router::new().get(hello),
).hoop(Cors::very_permissive().into_handler());
Server::new(acceptor).serve(service).await;

❯ http OPTIONS http://localhost:8000
HTTP/1.1 204 No Content

[tennox]

Or is this actually a bug, not a docs problem?

[chrislearn]

You can give document repository a PR.
https://github.com/salvo-rs/website

[tennox]

#1072

[tennox]

Or is this actually a bug, not a docs problem?

I guess the change was introduced in this commit:
ff4c1be#diff-f93b991bdb7ec06b8705f2ddf41de65e4a69afc0940c5c5c32b643454ec2bee1

Was it on purpose to break the router way of adding hoops, and you forgot to update the docs?
Or is it a regression?

[tennox]

While we're at it - I'm not quite grokking the concept of a Service - and it's not really mentioned in the docs book... Only section I found was this: https://salvo.rs/book/concepts/handler.html#what-is-handler - and that is only confusing me more, to be honest.