Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[draft] Salt-ssh can deploy a relenv environment #66878

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Akm0d
Copy link
Contributor

@Akm0d Akm0d commented Sep 10, 2024

What does this PR do?

This PR adds a new --relenv option to salt-ssh that deploys a relenv (onedir) bundled version of Salt and Python on the SSH target. The --relenv option works similarly to --thin but deploys a bundled Salt environment for cases where it’s preferable to use relenv.

What issues does this PR fix or reference?

Fixes #66877

Previous Behavior

Salt-ssh only supported the --thin option, which deploys a minimal Salt environment.

New Behavior

The new --relenv option allows salt-ssh to deploy a full Salt environment bundled with Python, offering more flexibility in environments where relenv is preferable. This will eventually become the new default, but for now, it remains an option.

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes

@Akm0d Akm0d requested a review from a team as a code owner September 10, 2024 18:10
@salt-project-bot-prod-environment salt-project-bot-prod-environment bot changed the title Salt-ssh can deploy a relenv environment [master] Salt-ssh can deploy a relenv environment Sep 10, 2024
@Akm0d Akm0d changed the title [master] Salt-ssh can deploy a relenv environment [draft] Salt-ssh can deploy a relenv environment Sep 10, 2024
Copy link
Contributor

@dmurphy18 dmurphy18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget the changelog entry, and tests.

salt/client/ssh/__init__.py Outdated Show resolved Hide resolved
@twangboy
Copy link
Contributor

Failing lint and pre-commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] Add --relenv Option to salt-ssh for Using a Onedir Bundled Version of Salt+Python
3 participants