Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Feature flag does not seem to be passed to the service #75

Closed
gabrielSoudry opened this issue Feb 10, 2022 · 1 comment
Closed
Labels
bug Something isn't working

Comments

@gabrielSoudry
Copy link

gabrielSoudry commented Feb 10, 2022

Your setup

Formula commit hash / release tag

Master 92ab8cd

Versions reports (master & minion)

salt-call --versions-report
Salt Version:
Salt: 3004

Pillar / config used

prometheus:
  wanted:
    component:
      - node_exporter
      - prometheus
  exporters:
    node_exporter:
      textfile_collectors_dependencies: []
      textfile_collectors: {}
  pkg:
    use_upstream_archive: true
    component:
      node_exporter:
        version: v1.3.1
        archive:
          source_hash: 68f3802c2dd3980667e4ba65ea2e1fb03f4a4ba026cca375f15a0390ff850949 
        commands:
          - node_exporter
        service:
          args:
            collector.systemd: null
            collector.ntp: null
            collector.ntp.server-is-local: null
            web.listen-address: ":9300"
      prometheus:
        service:
          args:
            web.listen-address: 0.0.0.0:9090
            enable-feature: agent
        version: v2.33.1
        archive:
          source_hash: 55de29727fc4d3977d3400c54fa222ebb52755bd0201936f1e1052fea6f2b44b
        config:
          global:
            scrape_interval: 15s
            evaluation_interval: 15s
          scrape_configs:
            - job_name: 'prometheus'
              static_configs:
                - targets: ['localhost:9090']
            - job_name: 'node_exporter'
              scrape_interval: 5s
              honor_labels: true
              static_configs:
                - targets: ['pushgateway:9300']

Same as #74, I want to enable agent mode in the service but I have :

 prometheus.service - prometheus - prometheus service
     Loaded: loaded (/lib/systemd/system/prometheus.service; enabled; vendor preset: enabled)
     Active: active (running) since Thu 2022-02-10 15:17:30 CET; 4min 59s ago
       Docs: https://github.com/saltstack-formulas/prometheus-formula
   Main PID: 1050513 (prometheus)
      Tasks: 13 (limit: 18772)
     Memory: 31.7M
     CGroup: /system.slice/prometheus.service
             └─1050513 /opt/prometheus/prometheus-v2.33.1/prometheus --config.file=/etc/prometheus/prometheus.yml

Instead of :

prometheus.service - prometheus - prometheus service
     Loaded: loaded (/lib/systemd/system/prometheus.service; enabled; vendor preset: enabled)
     Active: active (running) since Thu 2022-02-10 15:17:30 CET; 4min 59s ago
       Docs: https://github.com/saltstack-formulas/prometheus-formula
   Main PID: 1050513 (prometheus)
      Tasks: 13 (limit: 18772)
     Memory: 31.7M
     CGroup: /system.slice/prometheus.service
             └─1050513 /opt/prometheus/prometheus-v2.33.1/prometheus --config.file=/etc/prometheus/prometheus.yml --enable-feature=agent 

I am really new in salt, I apologize in advance if my configuration is bad

@gabrielSoudry gabrielSoudry added the bug Something isn't working label Feb 10, 2022
@gabrielSoudry
Copy link
Author

Ok It's the same bug as #61, I close the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant