Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] events / worker_connections set to 768 in default configuration #261

Closed
arthurzenika opened this issue Dec 20, 2019 · 5 comments · Fixed by #262
Closed

[BUG] events / worker_connections set to 768 in default configuration #261

arthurzenika opened this issue Dec 20, 2019 · 5 comments · Fixed by #262
Labels
bug released

Comments

@arthurzenika
Copy link
Contributor

Bug details

Describe the bug

After upgrading to a new formula

                  +events {
                  +    worker_connections 768;
                  +}

https://nginx.org/en/docs/ngx_core_module.html#worker_connections seems to indicate a default of 512, what is the rational for this different default here ?
@myii
Copy link
Member

myii commented Dec 20, 2019

Looking through the history, that was introduced by @daks in 0fc5070 (#232); perhaps he has more information about it. Also relevant to this discussion:

@daks
Copy link
Member

daks commented Dec 22, 2019

Not sure why I added this setting, maybe just because tests didn't pass without it. May be worth to try without.

@myii
Copy link
Member

myii commented Dec 22, 2019

@daks Thanks, we'll modify the default to be 512, then.

myii added a commit to myii/nginx-formula that referenced this issue Dec 22, 2019
@myii
fix(map.jinja): use upstream default for worker_connections
49caf8c 
* Close saltstack-formulas#261
* https://nginx.org/en/docs/ngx_core_module.html#worker_connections
@myii myii mentioned this issue Dec 22, 2019
Merged
19 tasks
@myii
Copy link
Member

myii commented Dec 22, 2019

@arthurlogilab @daks I've prepared #262 to deal with this.

saltstack-formulas-travis pushed a commit that referenced this issue Dec 22, 2019
@semantic-release-bot
chore(release): 2.3.3 [skip ci]
5938e9d 
## [2.3.3](v2.3.2...v2.3.3) (2019-12-22)

### Bug Fixes

* **map.jinja:** use upstream default for `worker_connections` ([49caf8c](49caf8c)), closes [#261](#261)

### Continuous Integration

* **gemfile:** restrict `train` gem version until upstream fix [skip ci] ([09be54d](09be54d))
* **travis:** quote pathspecs used with `git ls-files` [skip ci] ([091c614](091c614))
* **travis:** run `shellcheck` during lint job [skip ci] ([ccf64d9](ccf64d9))
* **travis:** use `major.minor` for `semantic-release` version [skip ci] ([facbaa1](facbaa1))
@saltstack-formulas-travis
Copy link

🎉 This issue has been resolved in version 2.3.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(map.jinja): use upstream default for worker_connections myii/nginx-formula
4 participants
@daks @arthurzenika @myii @saltstack-formulas-travis