Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split file.recurse of plugins from nrpe.plugin #50

Open
dafyddj opened this issue Aug 21, 2017 · 1 comment
Open

Split file.recurse of plugins from nrpe.plugin #50

dafyddj opened this issue Aug 21, 2017 · 1 comment

Comments

@dafyddj
Copy link
Contributor

dafyddj commented Aug 21, 2017

nrpe-plugin-package:
pkg.installed:
- name: {{ nrpe.plugin }}
{% if 'nagios/nrpe/files/plugins' in salt['cp.list_master_dirs']() %}
{{ nrpe.plugin_dir }}:
file.recurse:
- source: salt://nagios/nrpe/files/plugins/
- clean: False
- file_mode: 0755
{% endif %}

These two states do not belong together. The NRPE plugin goes on the Nagios server, and the additional plugins belong on the monitored hosts.

I propose moving lines 7-13 to nagios.plugins, although that would obviously require a change for anyone depending on the current behaviour.

@aboe76
Copy link
Member

aboe76 commented Jul 6, 2018

@dafyddj please create a PR for this, so it can be reviewed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants