Don't restrict VM sizes to deprecated VirtualMachineSizeTypes #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @lkubb and @nicholasmhughes. Is it possible to merge this PR? It would help us out in using the extension. Thanks! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #61 +/- ##
=======================================
Coverage 49.39% 49.39%
=======================================
Files 19 19
Lines 911 911
Branches 31 31
=======================================
Hits 450 450
Misses 451 451
Partials 10 10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@mentos1386 Of course. Just to make sure (since I don't use this extension): From my understanding, this is backwards-compatible, right? |
|
@lkubb it should be yes. It's making the code less strict so it should accept all existing values. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR removes a lookup of the provided Virtual Machine size against the deprecated enum VirtualMachineSIzeTypes during cloud VM deployment. Any user-provided SKU that isn't present in this deprecated enum will fail to deploy, despite the error message from Azure containing the SKU in its list of valid values.
What issues does this PR fix or reference?
Fixes: #56
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
No