Skip to content

Integration with Ember.Logger? #7

@rmharrison

Description

@rmharrison

Q: How difficult would it be to use Ember.Logger.debug instead of this.debug? Have not overwritten Ember core components before, and was hoping for a bit of guidance within the context of ember-debug-logger, possibly for a PR.

My issue with this.debug is the difficulty of refactoring/adding additional functionality beyond the scope of ember-debug-logger. For example, while console logging is great for now, I know I'll want to injest JSON-formatted log files, either to a 1st-party logging end-point I create or a 3rd-party service (AWS CloudWatch, Airbrake, Rollbar, etc.)

If this.debug were wrapped in Ember.Logger.debug, I could include these additional log streams at Ember.Logger.debug without touching ember-debug-logger.

There is precedent in the community. For example, ember-cli-rollbar rollbar.critical(msg) <--> Ember.Logger.error(msg), see: https://github.com/davewasmer/ember-cli-rollbar/blob/master/app/initializers/rollbar.js#L8

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions