Guard against fatal error if this.$() is undefined #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

pwfisher wants to merge 1 commit into salsify:master from pwfisher:guard-fatal

pwfisher commented Jun 28, 2017

No description provided.


          Guard against fatal error if this.$() is undefined

b6840c6

Member

dfreeman commented Jun 30, 2017

Hi @pwfisher — thanks for the PR! Can you describe the scenario this is fixing? I'm not clear on when this.$() will return undefined.

dfreeman added the need-submitter-response label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

need-submitter-response