fix: change deprecation messages to avoid undefined command id (#779)

WillieRuemmele · web-flow · commit e8e0aca995b2 · 2023-03-23T09:13:09.000-06:00
* fix: change deprecation messages to avoid undefined command id

* chore: deprecate source:push
diff --git a/messages/cancel.md b/messages/cancel.md
@@ -36,4 +36,4 @@ The cancel command failed due to: %s
 
 # deprecation
 
-The '<%= command.id %>' command will be deprecated. Try using the %s command instead.
+This command will be deprecated. Try using the '%s' command instead.
diff --git a/messages/deploy.md b/messages/deploy.md
@@ -262,4 +262,4 @@ You requested an async deploy with code coverage or JUnit results. The reports w
 
 # deprecation
 
-The '<%= command.id %>' command will be deprecated. Try using the %s command instead.
+This command will be deprecated. Try using the '%s' command instead.
diff --git a/messages/ignored_list.md b/messages/ignored_list.md
@@ -18,4 +18,4 @@ File or directory '%s' doesn't exist in your project. Specify one that exists an
 
 # deprecation
 
-The '<%= command.id %>' command will be deprecated. Try using the %s command instead.
+This command will be deprecated. Try using the '%s' command instead.
diff --git a/messages/md.cancel.md b/messages/md.cancel.md
@@ -43,4 +43,4 @@ The cancel command failed due to: %s
 
 # deprecation
 
-The '<%= command.id %>' command will be deprecated. Try using the %s command instead.
+This command will be deprecated. Try using the '%s' command instead.
diff --git a/messages/md.deploy.md b/messages/md.deploy.md
@@ -198,4 +198,4 @@ You requested an async deploy with code coverage or JUnit results. The reports w
 
 # deprecation
 
-The '<%= command.id %>' command will be deprecated. Try using the %s command instead.
+This command will be deprecated. Try using the '%s' command instead.
diff --git a/messages/md.deployreport.md b/messages/md.deployreport.md
@@ -62,4 +62,4 @@ Using specified username %s
 
 # deprecation
 
-The '<%= command.id %>' command will be deprecated. Try using the %s command instead.
+This command will be deprecated. Try using the '%s' command instead.
diff --git a/messages/md.retrieve.md b/messages/md.retrieve.md
@@ -143,4 +143,4 @@ If the retrieve request has completed, the retrieved metadata zip file will be w
 
 # deprecation
 
-The '<%= command.id %>' command will be deprecated. Try using the %s command instead.
+This command will be deprecated. Try using the '%s' command instead.
diff --git a/messages/pull.md b/messages/pull.md
@@ -56,4 +56,4 @@ Your retrieve request did not complete within the specified wait time [%s minute
 
 # deprecation
 
-The '<%= command.id %>' command will be deprecated. Try using the %s command instead.
+This command will be deprecated. Try using the '%s' command instead.
diff --git a/messages/push.md b/messages/push.md
@@ -52,4 +52,4 @@ Check the order of your dependencies and ensure all metadata is included.
 
 # deprecation
 
-The '<%= command.id %>' command will be deprecated. Try using the %s command instead.
+This command will be deprecated. Try using the '%s' command instead.
diff --git a/messages/report.md b/messages/report.md
@@ -59,4 +59,4 @@ The metadata deploy operation failed.
 
 # deprecation
 
-The '<%= command.id %>' command will be deprecated. Try using the %s command instead.
+This command will be deprecated. Try using the '%s' command instead.
diff --git a/messages/retrieve.md b/messages/retrieve.md
@@ -186,4 +186,4 @@ The retrieve target directory [%s] overlaps one of your package directories. Spe
 
 # deprecation
 
-The '<%= command.id %>' command will be deprecated. Try using the %s command instead.
+This command will be deprecated. Try using the '%s' command instead.
diff --git a/messages/status.md b/messages/status.md
@@ -54,4 +54,4 @@ No local or remote changes found.
 
 # deprecation
 
-The '<%= command.id %>' command will be deprecated. Try using the %s command instead.
+This command will be deprecated. Try using the '%s' command instead.
diff --git a/src/commands/force/source/push.ts b/src/commands/force/source/push.ts
@@ -33,6 +33,7 @@ const deployMessages = Messages.loadMessages('@salesforce/plugin-source', 'deplo
 const replacement = 'project deploy start';
 
 export default class Push extends DeployCommand {
+  public static readonly state = 'deprecated';
   public static readonly deprecationOptions = {
     to: replacement,
     message: messages.getMessage('deprecation', [replacement]),

Original file line number	Diff line number	Diff line change
`@@ -36,4 +36,4 @@ The cancel command failed due to: %s`
`36`	`36`
`37`	`37`	`# deprecation`
`38`	`38`
`39`		`-The '<%= command.id %>' command will be deprecated. Try using the %s command instead.`
	`39`	`+This command will be deprecated. Try using the '%s' command instead.`
Original file line number	Diff line number	Diff line change
`@@ -262,4 +262,4 @@ You requested an async deploy with code coverage or JUnit results. The reports w`
`262`	`262`
`263`	`263`	`# deprecation`
`264`	`264`
`265`		`-The '<%= command.id %>' command will be deprecated. Try using the %s command instead.`
	`265`	`+This command will be deprecated. Try using the '%s' command instead.`
Original file line number	Diff line number	Diff line change
`@@ -18,4 +18,4 @@ File or directory '%s' doesn't exist in your project. Specify one that exists an`
`18`	`18`
`19`	`19`	`# deprecation`
`20`	`20`
`21`		`-The '<%= command.id %>' command will be deprecated. Try using the %s command instead.`
	`21`	`+This command will be deprecated. Try using the '%s' command instead.`
Original file line number	Diff line number	Diff line change
`@@ -43,4 +43,4 @@ The cancel command failed due to: %s`
`43`	`43`
`44`	`44`	`# deprecation`
`45`	`45`
`46`		`-The '<%= command.id %>' command will be deprecated. Try using the %s command instead.`
	`46`	`+This command will be deprecated. Try using the '%s' command instead.`
Original file line number	Diff line number	Diff line change
`@@ -198,4 +198,4 @@ You requested an async deploy with code coverage or JUnit results. The reports w`
`198`	`198`
`199`	`199`	`# deprecation`
`200`	`200`
`201`		`-The '<%= command.id %>' command will be deprecated. Try using the %s command instead.`
	`201`	`+This command will be deprecated. Try using the '%s' command instead.`
Original file line number	Diff line number	Diff line change
`@@ -62,4 +62,4 @@ Using specified username %s`
`62`	`62`
`63`	`63`	`# deprecation`
`64`	`64`
`65`		`-The '<%= command.id %>' command will be deprecated. Try using the %s command instead.`
	`65`	`+This command will be deprecated. Try using the '%s' command instead.`
Original file line number	Diff line number	Diff line change
`@@ -143,4 +143,4 @@ If the retrieve request has completed, the retrieved metadata zip file will be w`
`143`	`143`
`144`	`144`	`# deprecation`
`145`	`145`
`146`		`-The '<%= command.id %>' command will be deprecated. Try using the %s command instead.`
	`146`	`+This command will be deprecated. Try using the '%s' command instead.`
Original file line number	Diff line number	Diff line change
`@@ -56,4 +56,4 @@ Your retrieve request did not complete within the specified wait time [%s minute`
`56`	`56`
`57`	`57`	`# deprecation`
`58`	`58`
`59`		`-The '<%= command.id %>' command will be deprecated. Try using the %s command instead.`
	`59`	`+This command will be deprecated. Try using the '%s' command instead.`
Original file line number	Diff line number	Diff line change
`@@ -52,4 +52,4 @@ Check the order of your dependencies and ensure all metadata is included.`
`52`	`52`
`53`	`53`	`# deprecation`
`54`	`54`
`55`		`-The '<%= command.id %>' command will be deprecated. Try using the %s command instead.`
	`55`	`+This command will be deprecated. Try using the '%s' command instead.`
Original file line number	Diff line number	Diff line change
`@@ -59,4 +59,4 @@ The metadata deploy operation failed.`
`59`	`59`
`60`	`60`	`# deprecation`
`61`	`61`
`62`		`-The '<%= command.id %>' command will be deprecated. Try using the %s command instead.`
	`62`	`+This command will be deprecated. Try using the '%s' command instead.`