Skip to content

Commit b53510c

Browse files
fix: only listen to events once per package (#698)
* fix: only listen to events once per package * chore: bump SDR version * chore: bump SDR version Co-authored-by: Steve Hetzel <[email protected]>
1 parent 3e1bb5d commit b53510c

File tree

3 files changed

+23
-79
lines changed

3 files changed

+23
-79
lines changed

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
"@salesforce/command": "^5.2.35",
1313
"@salesforce/core": "^3.32.14",
1414
"@salesforce/kit": "^1.8.3",
15-
"@salesforce/source-deploy-retrieve": "^7.7.3",
15+
"@salesforce/source-deploy-retrieve": "^7.7.5",
1616
"@salesforce/source-tracking": "^2.2.18",
1717
"chalk": "^4.1.2",
1818
"got": "^11.8.3",
@@ -188,4 +188,4 @@
188188
"publishConfig": {
189189
"access": "public"
190190
}
191-
}
191+
}

src/commands/force/source/push.ts

Lines changed: 14 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -88,6 +88,20 @@ export default class Push extends DeployCommand {
8888
this.getSourceApiVersion(),
8989
this.isRestDeploy(),
9090
]);
91+
92+
// eslint-disable-next-line @typescript-eslint/require-await
93+
this.lifecycle.on('apiVersionDeploy', async (apiData: DeployVersionData) => {
94+
this.ux.log(
95+
deployMessages.getMessage('apiVersionMsgDetailed', [
96+
'Pushing',
97+
apiData.manifestVersion,
98+
this.org.getUsername(),
99+
apiData.apiVersion,
100+
apiData.webService,
101+
])
102+
);
103+
});
104+
91105
for (const componentSet of componentSets) {
92106
// intentionally to do this sequentially if there are multiple component sets
93107
/* eslint-disable no-await-in-loop */
@@ -107,18 +121,6 @@ export default class Push extends DeployCommand {
107121
await this.lifecycle.emit('predeploy', componentSet.toArray());
108122

109123
const username = this.org.getUsername();
110-
// eslint-disable-next-line @typescript-eslint/require-await
111-
this.lifecycle.on('apiVersionDeploy', async (apiData: DeployVersionData) => {
112-
this.ux.log(
113-
deployMessages.getMessage('apiVersionMsgDetailed', [
114-
'Pushing',
115-
apiData.manifestVersion,
116-
username,
117-
apiData.apiVersion,
118-
apiData.webService,
119-
])
120-
);
121-
});
122124

123125
const deploy = await componentSet.deploy({
124126
usernameOrConnection: username,

yarn.lock

Lines changed: 7 additions & 65 deletions
Original file line numberDiff line numberDiff line change
@@ -1097,30 +1097,7 @@
10971097
"@salesforce/ts-types" "^1.7.1"
10981098
chalk "^2.4.2"
10991099

1100-
"@salesforce/core@^3.23.9", "@salesforce/core@^3.24.0", "@salesforce/core@^3.25.1", "@salesforce/core@^3.31.19", "@salesforce/core@^3.32.11":
1101-
version "3.32.12"
1102-
resolved "https://registry.yarnpkg.com/@salesforce/core/-/core-3.32.12.tgz#853cc5b6a5f95d4896b2d34a40a6042ef9aa6d2c"
1103-
integrity sha512-27rqSiQWul7b/OkJs19FYDv2M/S4oI4efiGv+6sR7UWv7D7CG1P+0XpgLS3d9xRYF30h98n6VQr4W2a+BWFRvA==
1104-
dependencies:
1105-
"@salesforce/bunyan" "^2.0.0"
1106-
"@salesforce/kit" "^1.8.0"
1107-
"@salesforce/schemas" "^1.4.0"
1108-
"@salesforce/ts-types" "^1.5.21"
1109-
"@types/graceful-fs" "^4.1.5"
1110-
"@types/semver" "^7.3.13"
1111-
ajv "^8.11.2"
1112-
archiver "^5.3.0"
1113-
change-case "^4.1.2"
1114-
debug "^3.2.7"
1115-
faye "^1.4.0"
1116-
form-data "^4.0.0"
1117-
graceful-fs "^4.2.9"
1118-
js2xmlparser "^4.0.1"
1119-
jsforce "^2.0.0-beta.19"
1120-
jsonwebtoken "9.0.0"
1121-
ts-retry-promise "^0.7.0"
1122-
1123-
"@salesforce/core@^3.32.12", "@salesforce/core@^3.32.13", "@salesforce/core@^3.32.14":
1100+
"@salesforce/core@^3.23.9", "@salesforce/core@^3.24.0", "@salesforce/core@^3.25.1", "@salesforce/core@^3.31.19", "@salesforce/core@^3.32.11", "@salesforce/core@^3.32.12", "@salesforce/core@^3.32.13", "@salesforce/core@^3.32.14":
11241101
version "3.32.14"
11251102
resolved "https://registry.yarnpkg.com/@salesforce/core/-/core-3.32.14.tgz#8746656d72776f27bc2cbfba7344d4f7ddd236ca"
11261103
integrity sha512-2hpjdYgVFdi9Bgihw8skElhbCi3U0uowrsoCNljtCHrxnm+ORyqwsdDAnNemKUPBL9JGX4ASfWcD4m7F8m9Ysw==
@@ -1187,16 +1164,7 @@
11871164
typedoc-plugin-missing-exports "0.23.0"
11881165
typescript "^4.1.3"
11891166

1190-
"@salesforce/kit@^1.7.1", "@salesforce/kit@^1.8.0":
1191-
version "1.8.1"
1192-
resolved "https://registry.yarnpkg.com/@salesforce/kit/-/kit-1.8.1.tgz#289ca9f4094157c1deaa77cc72f295fdc71f043f"
1193-
integrity sha512-fCMKh7yWiWtl9C2OXamwkzxD7r6MddrsxKAvlMYZTrTeVG/wxrV03NIhARVkT0k12CsmWNYv83VSPobBAufiIA==
1194-
dependencies:
1195-
"@salesforce/ts-types" "^1.7.1"
1196-
shx "^0.3.3"
1197-
tslib "^2.2.0"
1198-
1199-
"@salesforce/kit@^1.8.3":
1167+
"@salesforce/kit@^1.7.1", "@salesforce/kit@^1.8.0", "@salesforce/kit@^1.8.3":
12001168
version "1.8.3"
12011169
resolved "https://registry.yarnpkg.com/@salesforce/kit/-/kit-1.8.3.tgz#b590b78a8618494c51534598a7eb0683ba0da3f2"
12021170
integrity sha512-p+0tWR2pyCAIjZwDXGhrYFPuLckX9fP3Xa6Jync9POeQBfDGyK9CRd1eaiWj+6BeDS9kwvgm5M6o+OptIEhEjw==
@@ -1294,29 +1262,10 @@
12941262
chalk "^4"
12951263
inquirer "^8.2.5"
12961264

1297-
"@salesforce/source-deploy-retrieve@^7.5.19":
1298-
version "7.7.0"
1299-
resolved "https://registry.yarnpkg.com/@salesforce/source-deploy-retrieve/-/source-deploy-retrieve-7.7.0.tgz#30b81028f27a196e37a68b591c761db4ee53ddd3"
1300-
integrity sha512-Lw6+e1oxFUZgw8cArcE3wXGIJyPWC18eMIkF+oGD8ZhEEcQavAEzxLAKsYMrzZyIDXP/6dqZ5/McdJ1FAfe5BQ==
1301-
dependencies:
1302-
"@salesforce/core" "^3.32.12"
1303-
"@salesforce/kit" "^1.8.0"
1304-
"@salesforce/ts-types" "^1.7.2"
1305-
archiver "^5.3.1"
1306-
fast-xml-parser "^3.21.1"
1307-
got "^11.8.6"
1308-
graceful-fs "^4.2.10"
1309-
ignore "^5.2.4"
1310-
mime "2.6.0"
1311-
minimatch "^5.1.2"
1312-
proxy-agent "^5.0.0"
1313-
proxy-from-env "^1.1.0"
1314-
unzipper "0.10.11"
1315-
1316-
"@salesforce/source-deploy-retrieve@^7.7.3":
1317-
version "7.7.3"
1318-
resolved "https://registry.yarnpkg.com/@salesforce/source-deploy-retrieve/-/source-deploy-retrieve-7.7.3.tgz#476d4bae3cd74330ca0c65c74f7bf60999b9513d"
1319-
integrity sha512-CPn5AqsFLz9ZIFgL+4NmOwiizO4xWNelwdLan/aTzUqmxPo+XSZ8MYU+tD/1Pe8/fjmzLh/iYePiAMpXdphGRw==
1265+
"@salesforce/source-deploy-retrieve@^7.5.19", "@salesforce/source-deploy-retrieve@^7.7.3", "@salesforce/source-deploy-retrieve@^7.7.5":
1266+
version "7.7.5"
1267+
resolved "https://registry.yarnpkg.com/@salesforce/source-deploy-retrieve/-/source-deploy-retrieve-7.7.5.tgz#4eb64f02d4759f98e1e64187a081c472ebe8a2ae"
1268+
integrity sha512-zkGpbvTVr2nBJfbTxShFfaa4DAOvbXiaaWjZg0oVLUDoAQh+uQKX4aPdsXqJR4pKdQR8u1JwEV7TlR1f5gMCrg==
13201269
dependencies:
13211270
"@salesforce/core" "^3.32.13"
13221271
"@salesforce/kit" "^1.8.0"
@@ -5723,14 +5672,7 @@ [email protected]:
57235672
dependencies:
57245673
brace-expansion "^1.1.7"
57255674

5726-
minimatch@^5.0.1, minimatch@^5.1.0:
5727-
version "5.1.2"
5728-
resolved "https://registry.yarnpkg.com/minimatch/-/minimatch-5.1.2.tgz#0939d7d6f0898acbd1508abe534d1929368a8fff"
5729-
integrity sha512-bNH9mmM9qsJ2X4r2Nat1B//1dJVcn3+iBLa3IgqJ7EbGaDNepL9QSHOxN4ng33s52VMMhhIfgCYDk3C4ZmlDAg==
5730-
dependencies:
5731-
brace-expansion "^2.0.1"
5732-
5733-
minimatch@^5.1.2:
5675+
minimatch@^5.0.1, minimatch@^5.1.0, minimatch@^5.1.2:
57345676
version "5.1.6"
57355677
resolved "https://registry.yarnpkg.com/minimatch/-/minimatch-5.1.6.tgz#1cfcb8cf5522ea69952cd2af95ae09477f122a96"
57365678
integrity sha512-lKwV/1brpG6mBUFHtb7NUmtABCb2WZZmm2wNiOA5hAb8VdCS4B3dtMWyvcoViccwAW/COERjXLt0zP1zXUN26g==

0 commit comments

Comments
 (0)