Skip to content

Commit cc76449

Browse files
committed
nbgrader: lowercase spelling, address most of #8283
1 parent a9c6ddc commit cc76449

35 files changed

+1042
-238
lines changed

src/packages/frontend/course/commands.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,7 @@ export const COMMANDS: { [name: string]: Command } = {
156156
icon: "graduation-cap",
157157
label: defineMessage({
158158
id: "course.commands.nbgrader.label",
159-
defaultMessage: "Configure Nbgrader",
159+
defaultMessage: "Configure nbgrader",
160160
}),
161161
button: labels.nbgrader,
162162
title: defineMessage({
@@ -185,7 +185,7 @@ export const COMMANDS: { [name: string]: Command } = {
185185
"network-file-systems": {
186186
icon: "database",
187187
label: labels.cloud_storage_remote_filesystems,
188-
button: "Nbgrader",
188+
button: labels.nbgrader,
189189
title: defineMessage({
190190
id: "course.commands.network-file-systems.tooltip",
191191
defaultMessage:

src/packages/frontend/course/configuration/actions.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -289,7 +289,7 @@ export class ConfigurationActions {
289289
});
290290
}
291291

292-
// we also make sure all teachers have access to that project – otherwise NBGrader can't work, etc.
292+
// we also make sure all teachers have access to that project – otherwise nbgrader can't work, etc.
293293
// this has to happen *after* setting the course field, extended access control, ...
294294
const ps = redux.getStore("projects");
295295
const teachers = ps.get_users(store.get("course_project_id"));

src/packages/frontend/course/configuration/nbgrader.tsx

Lines changed: 13 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@
33
* License: MS-RSL – see LICENSE.md for details
44
*/
55

6+
import { Card, InputNumber, Radio } from "antd";
7+
68
import { Checkbox } from "@cocalc/frontend/antd-bootstrap";
79
import {
810
CSS,
@@ -11,9 +13,8 @@ import {
1113
useRedux,
1214
} from "@cocalc/frontend/app-framework";
1315
import { A, Icon } from "@cocalc/frontend/components";
14-
import { InputNumber } from "antd";
1516
import { SelectProject } from "@cocalc/frontend/projects/select-project";
16-
import { Card, Radio } from "antd";
17+
1718
import { CourseActions } from "../actions";
1819
import {
1920
NBGRADER_CELL_TIMEOUT_MS,
@@ -26,7 +27,7 @@ const radioStyle: CSS = {
2627
display: "block",
2728
whiteSpace: "normal",
2829
fontWeight: "inherit",
29-
};
30+
} as const;
3031

3132
interface Props {
3233
name: string;
@@ -106,7 +107,7 @@ export function Nbgrader({ name }: Props) {
106107
You can create a new project dedicated to running nbgrader, upgrade or
107108
license it appropriately, and copy any files to it that student work
108109
depends on. This new project will be shared will all collaborators of
109-
this instructorproject.
110+
this instructor project.
110111
<br />
111112
You can also grade all student work in the student's own project, which
112113
is good because the code runs in the same environment as the student
@@ -126,7 +127,7 @@ export function Nbgrader({ name }: Props) {
126127
}}
127128
>
128129
<h6>
129-
Nbgrader hidden tests:{" "}
130+
nbgrader hidden tests:{" "}
130131
{settings?.get("nbgrader_include_hidden_tests")
131132
? "Included"
132133
: "NOT included"}
@@ -163,7 +164,7 @@ export function Nbgrader({ name }: Props) {
163164
borderRadius: "5px",
164165
}}
165166
>
166-
<h6>Nbgrader timeouts: {timeout} seconds</h6>
167+
<h6>nbgrader timeouts: {timeout} seconds</h6>
167168
<i>Grading timeout in seconds:</i> if grading a student notebook takes
168169
longer than <i>{timeout} seconds</i>, then it is terminated with a
169170
timeout error.
@@ -213,7 +214,7 @@ export function Nbgrader({ name }: Props) {
213214
borderRadius: "5px",
214215
}}
215216
>
216-
<h6>Nbgrader output limits: {Math.round(max_output / 1000)} KB</h6>
217+
<h6>nbgrader output limits: {Math.round(max_output / 1000)} KB</h6>
217218
<i>Max output:</i> if total output from all cells exceeds{" "}
218219
{Math.round(max_output / 1000)} KB, then further output is truncated.
219220
<InputNumber
@@ -258,7 +259,7 @@ export function Nbgrader({ name }: Props) {
258259
}}
259260
>
260261
<h6>
261-
Nbgrader parallel limit:{" "}
262+
nbgrader parallel limit:{" "}
262263
{parallel > 1
263264
? `grade ${parallel} students at once`
264265
: "one student a time"}
@@ -282,9 +283,10 @@ export function Nbgrader({ name }: Props) {
282283
return (
283284
<Card
284285
title={
285-
<A href="https://doc.cocalc.com/teaching-nbgrader.html">
286-
<Icon name="graduation-cap" /> Nbgrader
287-
</A>
286+
<>
287+
<Icon name="graduation-cap" /> nbgrader (
288+
<A href="https://doc.cocalc.com/teaching-nbgrader.html">Docs</A>)
289+
</>
288290
}
289291
>
290292
{render_grade_project()}

src/packages/frontend/course/nbgrader/nbgrader-button.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ export function NbgraderButton({ name, assignment_id }: Props) {
5656
const n = settings.get("nbgrader_parallel") ?? PARALLEL_DEFAULT;
5757
return (
5858
<Tip
59-
title={`Nbgrader parallel limit: grade ${n} students at once`}
59+
title={`nbgrader parallel limit: grade ${n} students at once`}
6060
tip="This is the max number of students to grade in parallel. Change this in course configuration."
6161
>
6262
<div style={{ marginTop: "5px", fontWeight: 400 }}>
@@ -150,10 +150,10 @@ export function NbgraderButton({ name, assignment_id }: Props) {
150150
<span>
151151
{" "}
152152
<Icon name="cocalc-ring" spin />
153-
<Gap /> Nbgrader is running
153+
<Gap /> nbgrader is running
154154
</span>
155155
) : (
156-
<span>Nbgrader...</span>
156+
<span>nbgrader...</span>
157157
);
158158
return (
159159
<div style={{ margin: "5px 0" }}>

src/packages/frontend/cspell.json

Lines changed: 15 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,11 @@
33
"language": "en",
44
"enabled": true,
55
"words": [
6+
"autograde",
7+
"autograding",
68
"Bioconductor",
79
"CoCalc",
10+
"conat",
811
"dplyr",
912
"ggplot",
1013
"ipython",
@@ -24,12 +27,14 @@
2427
"rclass",
2528
"rereturn",
2629
"respawns",
30+
"revealjs",
2731
"Rmarkdown",
2832
"rtypes",
2933
"Sagemath",
3034
"sagetex",
3135
"sagews",
3236
"scikit",
37+
"SocketIO",
3338
"statsmodels",
3439
"syncdb",
3540
"syncdoc",
@@ -41,14 +46,14 @@
4146
"timetravel",
4247
"tolerations",
4348
"undelete",
44-
"undeleting",
45-
"revealjs",
46-
"conat",
47-
"SocketIO"
49+
"undeleting"
4850
],
4951
"ignoreWords": [
5052
"antd",
53+
"buttonbar",
5154
"collab",
55+
"flyoutdragbar",
56+
"flyouts",
5257
"immutablejs",
5358
"ipynb",
5459
"isdir",
@@ -60,21 +65,18 @@
6065
"mesg",
6166
"mintime",
6267
"mistralai",
68+
"noconf",
69+
"nprocs",
70+
"pchildren",
71+
"pids",
6372
"Popconfirm",
6473
"PoweroffOutlined",
74+
"ptree",
6575
"reuseinflight",
6676
"sidechat",
6777
"vertexai",
6878
"vfill",
69-
"xsmall",
70-
"flyouts",
71-
"buttonbar",
72-
"noconf",
73-
"flyoutdragbar",
74-
"ptree",
75-
"pchildren",
76-
"nprocs",
77-
"pids"
79+
"xsmall"
7880
],
7981
"flagWords": [],
8082
"ignorePaths": ["node_modules/**", "dist/**", "dist-ts/**", "build/**"],

src/packages/frontend/i18n/common.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -689,7 +689,7 @@ export const labels = defineMessages({
689689
},
690690
nbgrader: {
691691
id: "labels.nbgrader",
692-
defaultMessage: "NBgrader",
692+
defaultMessage: "nbgrader",
693693
},
694694
name: { id: "labels.name", defaultMessage: "Name" },
695695
description: { id: "labels.description", defaultMessage: "Description" },

0 commit comments

Comments
 (0)