Skip to content

Conversation

@vincentmacri
Copy link
Member

@vincentmacri vincentmacri commented Dec 5, 2025

Fixes a pickling issue I encountered while working on some function field improvements. This lets us enable some additional tests for Jacobians of function fields that were disabled due to a pickling issue with projective curves.

Previously the _open_affine and _map_from_function_field properties of projective curves would fail to pickle. We solve this by not storing them in the pickle since they are easy to recompute.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@vincentmacri vincentmacri changed the title Fix for projective curve pickling Fix for projective curve pickling, enabling more tests for function field Jacobians Dec 5, 2025
@kwankyu
Copy link
Collaborator

kwankyu commented Dec 8, 2025

LGTM. Would you merge develop to test?

@github-actions
Copy link

github-actions bot commented Dec 8, 2025

Documentation preview for this PR (built with commit 0f91b6d; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@vincentmacri
Copy link
Member Author

Test failures are unrelated as far as I can tell. @kwankyu anything else?

@kwankyu
Copy link
Collaborator

kwankyu commented Dec 9, 2025

.. @kwankyu anything else?

No. Thanks.

@vincentmacri
Copy link
Member Author

Thanks for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants