-
-
Notifications
You must be signed in to change notification settings - Fork 718
Fix for projective curve pickling, enabling more tests for function field Jacobians #41265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vincentmacri
wants to merge
5
commits into
sagemath:develop
Choose a base branch
from
vincentmacri:projective_curve_pickling
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix for projective curve pickling, enabling more tests for function field Jacobians #41265
vincentmacri
wants to merge
5
commits into
sagemath:develop
from
vincentmacri:projective_curve_pickling
+90
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincentmacri
commented
Dec 5, 2025
Collaborator
|
LGTM. Would you merge |
|
Documentation preview for this PR (built with commit 0f91b6d; changes) is ready! 🎉 |
Member
Author
|
Test failures are unrelated as far as I can tell. @kwankyu anything else? |
Collaborator
No. Thanks. |
kwankyu
approved these changes
Dec 9, 2025
Member
Author
|
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a pickling issue I encountered while working on some function field improvements. This lets us enable some additional tests for Jacobians of function fields that were disabled due to a pickling issue with projective curves.
Previously the
_open_affineand_map_from_function_fieldproperties of projective curves would fail to pickle. We solve this by not storing them in the pickle since they are easy to recompute.📝 Checklist
⌛ Dependencies