some fixes from UP027 #41172
Open
some fixes from UP027 #41172
+45
−47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincentmacri
added
s: positive review
t: refactoring
and removed
s: needs review
labels
Member
|
According to the ruff docs there is no reason to use the UP027 rule, the performance impact is neutral and the rule is deprecated. https://docs.astral.sh/ruff/rules/unpacked-list-comprehension/ Approving because the impact of the rule is neutral and the added type annotations are good, but no need to worry about fixing this rule elsewhere. |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Nov 16, 2025
sagemathgh-41172: some fixes from UP027 about not creating a list when an iterator could do ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. URL: sagemath#41172 Reported by: Frédéric Chapoton Reviewer(s):
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
about not creating a list when an iterator could do
📝 Checklist