Skip to content

Commit 44c09ad

Browse files
author
Release Manager
committed
gh-40527: Refactor sage.groups.generic Previously, the code to check `in addition_names`, `in multiplication_names`, error checking etc. are duplicated everywhere. Now it's collated into a helper function. Besides, previously sometimes these group definition arguments are not correctly passed to subclasses. Now they are. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - #12345: short description why this is a dependency --> <!-- - #34567: ... --> URL: #40527 Reported by: user202729 Reviewer(s): Lorenz Panny, user202729
2 parents 46b3f79 + 454125e commit 44c09ad

File tree

1 file changed

+192
-142
lines changed

1 file changed

+192
-142
lines changed

0 commit comments

Comments
 (0)