Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting DNS servers #364

Open
DBLouis opened this issue Nov 16, 2021 · 2 comments
Open

Setting DNS servers #364

DBLouis opened this issue Nov 16, 2021 · 2 comments

Comments

@DBLouis
Copy link
Contributor

DBLouis commented Nov 16, 2021

Would you consider re-adding this functionality under a non-default cargo feature?

9cec74c

@sagebind
Copy link
Owner

I might consider restoring such an option under an optional feature. Since it only works when curl is compiled with c-ares support (which it typically isn't) it should retain a pretty clear warning label as such.

I was also not a fan of the previous warn-by-default behavior. If possible the API ought to error early if the option is not supported at runtime.

@DBLouis
Copy link
Contributor Author

DBLouis commented Nov 23, 2021

I made a PR at alexcrichton/curl-rust#427

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants