Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update requests to use non-contextual entered spans #304

Open
sagebind opened this issue Feb 20, 2021 · 0 comments
Open

Update requests to use non-contextual entered spans #304

sagebind opened this issue Feb 20, 2021 · 0 comments
Labels
enhancement Make a feature better

Comments

@sagebind
Copy link
Owner

The way our tracing support currently works is that we re-enter and exit a single span for each request which is passed around the system. This was really the only way of doing it previously, but conceptually doesn't really make sense since the request isn't starting and stopping, but rather ongoing until it completes. Based on tokio-rs/tracing#1252 it looks like it might be possible for us to change this soon.

See also tokio-rs/tracing#79.
@sagebind sagebind added the enhancement Make a feature better label Feb 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Make a feature better
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sagebind