Skip to content

Commit 9969152

Browse files
committed
Fix dropdown not opening after closing
Signed-off-by: Christopher Ng <[email protected]>
1 parent 8577536 commit 9969152

File tree

3 files changed

+15
-0
lines changed

3 files changed

+15
-0
lines changed

src/components/Select.vue

+4
Original file line numberDiff line numberDiff line change
@@ -1317,6 +1317,10 @@ export default {
13171317
onSearchKeyDown(e) {
13181318
const preventAndSelect = (e) => {
13191319
e.preventDefault()
1320+
if (!this.open) {
1321+
this.open = true
1322+
return
1323+
}
13201324
return !this.isComposing && this.typeAheadSelect()
13211325
}
13221326

tests/unit/Dropdown.spec.js

+9
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,15 @@ describe('Toggling Dropdown', () => {
6363
expect(Select.vm.search).toEqual('')
6464
})
6565

66+
it('should open dropdown on selectOnKeyCodes keydown', async () => {
67+
const Select = mountDefault()
68+
const input = Select.findComponent({ ref: 'search' })
69+
70+
input.trigger('keydown.enter')
71+
72+
expect(Select.vm.open).toEqual(true)
73+
})
74+
6675
it('should open dropdown on alphabetic input', async () => {
6776
const Select = mountDefault()
6877
const input = Select.findComponent({ ref: 'search' })

tests/unit/Keydown.spec.js

+2
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ describe('Custom Keydown Handlers', () => {
1919

2020
const spy = jest.spyOn(Select.vm, 'typeAheadSelect')
2121

22+
Select.vm.open = true
2223
Select.findComponent({ ref: 'search' }).trigger('keydown.space')
2324

2425
expect(spy).toHaveBeenCalledTimes(1)
@@ -33,6 +34,7 @@ describe('Custom Keydown Handlers', () => {
3334

3435
const spy = jest.spyOn(Select.vm, 'typeAheadSelect')
3536

37+
Select.vm.open = true
3638
Select.findComponent({ ref: 'search' }).trigger('keydown.space')
3739
expect(onKeyDown.mock.calls.length).toBe(1)
3840

0 commit comments

Comments
 (0)