zip files that cause grader exceptions

[bill-auger]

if the auto-grader is giving errors for your HW5 submission please drag and drop your zip file into a comment below

HusainJaffer, gpincheiraa, weiherj, nbartowski, siderio2 files result in this error:

Running student tests found in features/ spec/:

/home/ubuntu/.rvm/rubies/ruby-2.2.2/bin/ruby -S bundle exec cucumber  --profile default

/home/ubuntu/.rvm/rubies/ruby-2.2.2/bin/ruby -I/home/ubuntu/.rvm/gems/ruby-2.2.2/gems/rspec-core-3.3.2/lib:/home/ubuntu/.rvm/gems/ruby-2.2.2/gems/rspec-support-3.3.0/lib /home/ubuntu/.rvm/gems/ruby-2.2.2/gems/rspec-core-3.3.2/exe/rspec --pattern spec/\*\*\{,/\*/\*\*\}/\*_spec.rb failed

---

nbartowski and zarak seem to have hit the perennial factory girl issue

nbartowski's file gives

  1) Movie finding movie list with same director as Star Wars should return list of movies with same director
     Failure/Error: @movie = FactoryGirl.create(:movie, :title => 'Star Wars',
     ActiveRecord::RecordNotUnique:
       SQLite3::ConstraintException: UNIQUE constraint failed: movies.id: INSERT INTO "movies" ("title", "rating", "release_date", "director", "id", "created_at", "updated_at") VALUES (?, ?, ?, ?, ?, ?, ?)

  2) Movie finding movie list with same director as Star Wars should not return movies with a different director
     Failure/Error: @movie = FactoryGirl.create(:movie, :title => 'Star Wars',
     ActiveRecord::RecordNotUnique:
       SQLite3::ConstraintException: UNIQUE constraint failed: movies.id: INSERT INTO "movies" ("title", "rating", "release_date", "director", "id", "created_at", "updated_at") VALUES (?, ?, ?, ?, ?, ?, ?)

zarak's file gives

FactoryGirl::DuplicateDefinitionError: Factory already registered: movie

i have not investigated any of these yet

[HunterJaffer]

ARCHIVE_HIDDEN

[gpincheiraa]

ARCHIVE_HIDDEN

[HunterJaffer]

@bill-auger Do you by any chance know, if anyone from 2016 has gotten 100/100 for HW5 so far?

[bill-auger]

@HusainJaffer

i think there maybe something buggy with the grader for this assignment - i was able to get 100% but i had to do something very naughty - #24 is a discussion about it

[bill-auger]

student weiherj archive

ARCHIVE_HIDDEN

[HunterJaffer]

@bill-auger I was thinking of maybe blocking cucumber from loading in the .rb files in features/spec directory,and I also changed the homepage path to '/movies'

[alireza-a]

ARCHIVE_HIDDEN

[jeanwei]

ARCHIVE_HIDDEN

[anklinuxboy]

ARCHIVE_HIDDEN

My autograder output.

All rpsec tests pass and 16/17 cucumber tests pass. Don't know how to debug.
Your submission was recorded at 2016-07-14 03:46:28 +0000 : submission is on time.
Score: 0/100
There was a fatal error with your submission. It either timed out or caused an exception.

[tansaku]

@anklinuxboy I'm seeing this error for your code when I run against the grader locally:

/Users/tansaku/Documents/GitHub/saasbook/rag/lib/graders/feature_grader/hw4_grader.rb:157:in `block (2 levels) in setup_rails_app': == 20111119180638 CreateMovies: migrating ===================================== (RuntimeError)
-- create_table(:movies)
   -> 0.0012s
== 20111119180638 CreateMovies: migrated (0.0012s) ============================

== 20120130161449 AddMoreMovies: migrating ====================================
== 20120130161449 AddMoreMovies: migrated (0.0144s) ===========================

== 20160714005819 AddDirector: migrating ======================================
-- add_column(:movies, :director, :string)
   -> 0.0006s
== 20160714005819 AddDirector: migrated (0.0006s) =============================

== 20160714010253 AddDirectorToMovie: migrating ===============================
-- add_column(:movies, :director, :string)
DEPRECATION WARNING: `#timestamps` was called without specifying an option for `null`. In Rails 5, this behavior will change to `null: false`. You should manually specify `null: true` to prevent the behavior of your existing migrations from changing. (called from block in up at /Users/tansaku/Documents/GitHub/saasbook/rag/submissions/506af89a6181960fc69f47f1fbc8d708/assignment4/2016-07-15-10-57-18/db/migrate/20111119180638_create_movies.rb:10)
rake aborted!
StandardError: An error has occurred, this and all later migrations canceled:

SQLite3::SQLException: duplicate column name: director: ALTER TABLE "movies" ADD "director" varchar/Users/tansaku/.rvm/gems/ruby-2.2.2/gems/sqlite3-1.3.10/lib/sqlite3/database.rb:91:in `initialize'

looks like you have multiple migrations

[tansaku]

@HusainJaffer Running locally I see this error for the your zip file:

Failures:

  1) MoviesController GET #index assigns all movies as @movies
     Failure/Error: expect(assigns(:movies)).to eq([movie])

       expected: [#<Movie id: 11, title: "Aladdin", rating: "G", description: nil, release_date: "1992-11-25 00:00:00", created_at: "2016-07-15 10:08:09", updated_at: "2016-07-15 10:08:09", director: "James mooo">]
            got: #<ActiveRecord::Relation [#<Movie id: 1, title: "Aladdin", rating: "G", description: nil, release_date: "1992-11-25 00:00:00", created_at: "2016-07-15 10:08:01", updated_at: "2016-07-15 10:08:01", director: nil>, #<Movie id: 2, title: "The Terminator", rating: "R", description: nil, release_date: "1984-10-26 00:00:00", created_at: "2016-07-15 10:08:01", updated_at: "2016-07-15 10:08:01", director: nil>, #<Movie id: 3, title: "When Harry Met Sally", rating: "R", description: nil, release_date: "1989-07-21 00:00:00", created_at: "2016-07-15 10:08:01", updated_at: "2016-07-15 10:08:01", director: nil>, #<Movie id: 4, title: "The Help", rating: "PG-13", description: nil, release_date: "2011-08-10 00:00:00", created_at: "2016-07-15 10:08:01", updated_at: "2016-07-15 10:08:01", director: nil>, #<Movie id: 5, title: "Chocolat", rating: "PG-13", description: nil, release_date: "2001-01-05 00:00:00", created_at: "2016-07-15 10:08:01", updated_at: "2016-07-15 10:08:01", director: nil>, #<Movie id: 6, title: "Amelie", rating: "R", description: nil, release_date: "2001-04-25 00:00:00", created_at: "2016-07-15 10:08:01", updated_at: "2016-07-15 10:08:01", director: nil>, #<Movie id: 7, title: "2001: A Space Odyssey", rating: "G", description: nil, release_date: "1968-04-06 00:00:00", created_at: "2016-07-15 10:08:01", updated_at: "2016-07-15 10:08:01", director: nil>, #<Movie id: 8, title: "The Incredibles", rating: "PG", description: nil, release_date: "2004-11-05 00:00:00", created_at: "2016-07-15 10:08:01", updated_at: "2016-07-15 10:08:01", director: nil>, #<Movie id: 9, title: "Raiders of the Lost Ark", rating: "PG", description: nil, release_date: "1981-06-12 00:00:00", created_at: "2016-07-15 10:08:01", updated_at: "2016-07-15 10:08:01", director: nil>, #<Movie id: 10, title: "Chicken Run", rating: "G", description: nil, release_date: "2000-06-21 00:00:00", created_at: "2016-07-15 10:08:01", updated_at: "2016-07-15 10:08:01", director: nil>, ...]>

       (compared using ==)
...

Finished in 0.18305 seconds (files took 2.12 seconds to load)
31 examples, 1 failure

Failed examples:

rspec ./spec/controllers/movies_controller_spec.rb:36 # MoviesController GET #index assigns all movies as @movies

[tansaku]

@HusainJaffer, @gpincheiraa, @weiherj, @alireza-a, @anklinuxboy - I'd encourage you to all re-submit - I've just updated the grader to provide more details feedback on the issues you've been encountering.

Please also do ensure that everything runs for you locally before you submit to the autograder. Looking at some of these errors it seems like they should have been showing up for you on your local machines or C9.

[gpincheiraa]

@tansaku Thanks. I was sured that my homework in my local machine works. rspec passing all the tests and cucumber scenarios too.
I don't understand why in the autograder some test are failing, but i will work in those and try again. Thanks for adding more information in the log. Now I see the problems in rspec.

[weiherj]

@tansaku Thanks. The added feedback from the autograder was very helpful. I found my issue and fixed it.

[alireza-a]

do the tests depend on a specific version of "rspec-rails" ?