-
-
Notifications
You must be signed in to change notification settings - Fork 686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No longer maintained packages in the readme #1274
Comments
Hi @KaJe5380 , thanks for the request. Yes the plan is definitely link to just_audio_media_kit in the README, basically, to link to all federated implementations that work (thus also including just_audio_mpv, perhaps with the note you suggest). Have you had any experience testing just_audio_media_kit on windows and/or linux? |
I started some initial testing on Linux. There are some stuff I didn't get to,
Though I'm on Arch Linux (Kernel 6.9.7 - latest) I haven't test any of it on Windows, as I started moving my workflow to Linux in 2020 & dropped it entirely in 2023. |
Hi, I've been using and testing the package for a while now, and playback works (either streaming or locally, and with Pulse or Pipewire, though The caveats are listed here, the major one being the Gapless playback is marked as experimental, as libmpv does too (in my experience it works pretty well, though it might discard some downloaded content, thus downloading stuff uselessly). |
Excellent, thanks for confirming its stability @Pato05 . I'd like to try updating the examples here and also in audio_service to use just_audio_media_kit, and list it as the first choice since it is cross-platform. Also, it looks like flutter/flutter#80374 was finally resolved yesterday which means I can actually add just_audio_media_kit as an endorsed implementation to pubspec.yaml -- if you're open to that, of course. But there is no rush to decide on that, because I think it will still take time for that fix to make it into Flutter stable. If just_audio_media_kit is endorsed, it would then just make it automatically used as the default Linux/Windows implementation, although that default could in theory now be overridden with that new fix. (As just_audio is part of Flutter Favorites, though, I would just have to make sure that any endorsed implementation follows all of the same official practices that just_audio itself follows, such as strictly following the semantic versioning rules as they are interpreted by pub.dev. This is so that a breaking change to just_audio_media_kit, including such changes to its own dependencies would not be introduced without being reflected in the semantic version, otherwise it could end up breaking just_audio itself.) |
Nice.
Regarding this, I already use semantic versioning in |
Pub's rules for semantic versioning are at this link, which follows normal semantic versioning except that pub adds its own rules for versions pre 1.0.0. I see that just_audio_media_kit is post 1.0.0 so this distinction wouldn't matter. The main thing is that if just_audio depends on just_audio_media_kit ^2.0.0, then no breaking changes should be introduced in any version 2.x.x, including either to the public API or to its dependencies. So for example, when I recently bumped up the version of the rxdart dependency in just_audio, I used the constraint More broadly, the Flutter Favorite quality requirements are here but these are just what I must personally adhere to with just_audio itself. Although the last requirement is to also use high quality dependencies, so I think on your end, it would mainly be a matter of adhering to best practices regarding breaking changes. They mention unit test coverage further down the page, I don't think that's strictly necessary, although it wouldn't be a bad thing of course. The permissive license requirement is already met, I believe, since the GPL part of this is assumed to be installed separately outside of this package. |
To which pages does your suggestion apply?
Quote the sentences(s) from the documentation to be improved (if any)
Describe your suggestion
just_audio_mpv
&just_audio_libwinmedia
have been marked asDISCONTINUED
on pub.dev andreplaced by: just_audio_media_kit
for Linuxreplaced by: just_audio_windows
for Windows.just_audio_mpv's own GitHub no longer matches it's pub.dev readme, with the GitHub getting a new section 5 months ago:
just_audio_mpv
&just_audio_libwinmedia
should either be removed from documentation, or given parenthesis for no longer being maintained. Also addingjust_audio_media_kit
for Linux.Would also need to see if Linux's Platform support list still matches with this new library.
Edit:
Didn't see this initially, but you actually seem to know about this package in issue #1199 about this package.
The text was updated successfully, but these errors were encountered: