Fix stickers incorrectly retaining their constraint data when saved to Create contraptions (sorry for all the buggy builds)

Author: ryanhcode

neoforge/src/main/java/dev/ryanhcode/sable/neoforge/mixin/compatibility/create/sticker/ContraptionMixin.java

@@ -0,0 +1,25 @@
+package dev.ryanhcode.sable.neoforge.mixin.compatibility.create.sticker;
+
+import com.llamalad7.mixinextras.injector.wrapoperation.Operation;
+import com.llamalad7.mixinextras.injector.wrapoperation.WrapOperation;
+import com.simibubi.create.content.contraptions.Contraption;
+import dev.ryanhcode.sable.neoforge.mixinterface.compatibility.create.StickerBlockEntityExtension;
+import net.minecraft.core.HolderLookup;
+import net.minecraft.nbt.CompoundTag;
+import net.minecraft.world.level.block.entity.BlockEntity;
+import org.spongepowered.asm.mixin.Mixin;
+import org.spongepowered.asm.mixin.injection.At;
+
+@Mixin(Contraption.class)
+public class ContraptionMixin {
+
+    @WrapOperation(method = "getBlockEntityNBT", at = @At(value = "INVOKE", target = "Lnet/minecraft/world/level/block/entity/BlockEntity;saveWithFullMetadata(Lnet/minecraft/core/HolderLookup$Provider;)Lnet/minecraft/nbt/CompoundTag;"))
+    private CompoundTag sable$saveStickerNBT(final BlockEntity instance, final HolderLookup.Provider registries, final Operation<CompoundTag> original) {
+        if (instance instanceof final StickerBlockEntityExtension extension) {
+            extension.sable$saveToContraption(registries);
+        }
+        return original.call(instance, registries);
+    }
+
+
+}

neoforge/src/main/java/dev/ryanhcode/sable/neoforge/mixin/compatibility/create/sticker/StickerBlockEntityMixin.java

@@ -64,6 +64,12 @@ public abstract class StickerBlockEntityMixin extends SmartBlockEntity implement
     @Unique
     private boolean sable$hasConstraint;
 
+    /**
+     * kinda hacky but we ball
+     */
+    @Unique
+    private boolean sable$doNotSaveConstraint;
+
     private StickerBlockEntityMixin(final BlockEntityType<?> type, final BlockPos pos, final BlockState state) {
         super(type, pos, state);
     }
@@ -250,11 +256,18 @@ public void tick(final CallbackInfo ci) {
         this.sable$tickConstraint();
     }
 
+    @Override
+    public void sable$saveToContraption(final HolderLookup.Provider registries) {
+        this.sable$doNotSaveConstraint = true;
+        this.saveWithFullMetadata(registries);
+        this.sable$doNotSaveConstraint = false;
+    }
+
     @Inject(method = "write", at = @At("TAIL"))
     public void write(final CompoundTag compound, final HolderLookup.Provider registries, final boolean clientPacket, final CallbackInfo ci) {
         if (clientPacket) {
             compound.putBoolean("SableHasConstraint", this.sable$handle != null);
-        } else if (this.sable$handle != null) {
+        } else if (this.sable$handle != null && !this.sable$doNotSaveConstraint) {
             final CompoundTag constraint = new CompoundTag();
             final BlockPos blockPos = this.getBlockPos();
             constraint.putInt("ThisX", blockPos.getX());

neoforge/src/main/java/dev/ryanhcode/sable/neoforge/mixinterface/compatibility/create/StickerBlockEntityExtension.java

@@ -1,9 +1,13 @@
 package dev.ryanhcode.sable.neoforge.mixinterface.compatibility.create;
 
 
+import net.minecraft.core.HolderLookup;
+
 public interface StickerBlockEntityExtension {
 
     void sable$removeConstraint();
 
     void sable$tickConstraint();
+
+    void sable$saveToContraption(HolderLookup.Provider registries);
 }

neoforge/src/main/resources/sable-neoforge.mixins.json

@@ -146,6 +146,7 @@
     "compatibility.create.schematics.SchematicPrinterMixin",
     "compatibility.create.schematics.SchematicToolBaseMixin",
     "compatibility.create.schematics.StructureTemplateMixin",
+    "compatibility.create.sticker.ContraptionMixin",
     "compatibility.create.sticker.StickerBlockEntityMixin",
     "compatibility.create.sticker.StickerBlockMixin",
     "compatibility.create.stock_ticker.StockTickerInteractionHandlerMixin",