Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mem leak in connect #21

Open
jonnymacs opened this issue Jun 15, 2019 · 0 comments
Open

mem leak in connect #21

jonnymacs opened this issue Jun 15, 2019 · 0 comments

Comments

@jonnymacs
Copy link

There is a memory leak caused by ElasticsearchClient.connect. The error closure holds a reference to the client that creates a circular reference such that the client is never deallocated.

removing the error closure resolves the memory leak, but I'm not sure the best way to resolve. This is working for me, and I can submit a PR if there are no other recommendations.

Steps to reproduce

Interact with elastic search while running xcode profiling instruments. Run generations to see the memory grow unbounded.

Expected behavior

client is deallocated

Actual behavior

Environment

  • Version/commit of the Elasticsearch client you are using
    latest

  • Version of Elasticsearch that you are using
    6.5

  • Vapor Framework version:
    3.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant