Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub remote needn't end in .git #87

Open
danvk opened this issue Oct 27, 2015 · 0 comments
Open

GitHub remote needn't end in .git #87

danvk opened this issue Oct 27, 2015 · 0 comments
Labels

Comments

@danvk
Copy link
Collaborator

danvk commented Oct 27, 2015

Looks like the assumption here is incorrect:

$ github pileup/README.md
Traceback (most recent call last):
  File "/Users/danvk/github/git-helpers/github/github", line 56, in <module>
    repo_url = github.make_github_url(remote)
  File "/Users/danvk/github/git-helpers/util/github.py", line 22, in make_github_url
    assert '.git' in remote
AssertionError
$ git remote -v
origin  https://github.com/hammerlab/internal-tools (fetch)
origin  https://github.com/hammerlab/internal-tools (push)

I guess the .git for a GitHub remote is optional, or perhaps git quietly adds it itself?

@danvk danvk added the bug label Oct 27, 2015
@danvk danvk changed the title git remote needn't end in .git GitHub remote needn't end in .git Oct 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant