Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add options for tabs and remove tabs from screen #5

Closed
LeoBorai opened this issue Jul 3, 2018 · 6 comments
Closed

Add options for tabs and remove tabs from screen #5

LeoBorai opened this issue Jul 3, 2018 · 6 comments

Comments

@LeoBorai
Copy link

LeoBorai commented Jul 3, 2018

I have been using the rxjs-playground and as I enjoy the way it works I had some trouble with the design of the editor and the output/console sections.

I was thinking about an approach where we can use tabs, close the inactive tabs and a settings section.

Thanks! Hope I can help with this!

@imbhargav5
Copy link
Member

Hey surely. Let me know if you have a plan / design for this. And we can take it from there.

@LeoBorai
Copy link
Author

LeoBorai commented Jul 3, 2018

I have some sketch, let me create the layout and then I will try to show you what I have in mind!

@LeoBorai
Copy link
Author

LeoBorai commented Jul 3, 2018

reactivexplayground
Here is my idea.

I was thinking about using Play, Stop and Repeat icons for Play, Stop and Clear buttons.

@imbhargav5
Copy link
Member

imbhargav5 commented Jul 3, 2018

Awww. Looks awesome. Go ahead if you would like to give this a try!! Thank you!

@LeoBorai
Copy link
Author

LeoBorai commented Jul 8, 2018

Hey @imbhargav5!,
I wanted you to know that I'm doing some changes to your app, I'm addding redux and changing a bit of the architecture of your app.

Hope you don't mind about those changes.

Thanks in advance!

@imbhargav5
Copy link
Member

imbhargav5 commented Jul 8, 2018 via email

@LeoBorai LeoBorai closed this as not planned Won't fix, can't repro, duplicate, stale Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants