-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple barcode decoder issue #51
Comments
I'll look into this. I'm out of office until next week, but I'll try to provide an update by midweek. |
Stepping through the detection logic it appears that you are correct. There is just enough distortion that one of the symbols fails error correction. The issue is that the datamatrix detector, unlike the qr detector, only returns a single possible symbol. For "multiple detection" this is usually fine because the image is then chopped up and rescanned, but in this particular case that does not occur and so only one symbol in the entire image is ever parsed. I have updated the logic of the detector to return all possible symbol locations and to iterate over them. This has a slight reduction in performance in some cases, but overall should result in better detection results. I have a working fix in testing. |
This changes how datamatrix symbols are detected in an image. Previously only the first possible symbol was returned. After this change all possible symbols are returned. This addresses the issue presented in #51
🙏 Thanks |
This release has been published to crates.io and to rxing-wasm v0.2.9 |
Hello,
First of all, thank you for all the work you have done.
I am encountering an issue with the detection of multiple DataMatrix codes in an image.
In the image below, we get an error of type
Err(NotFoundException(""))
because the first DataMatrix code in the image is, I believe, detected but is blurry on its right side (you can see it clearly by zooming in). However, the second DataMatrix code is good but not detected.If I swap the two DataMatrix codes, the first one is detected and everything works as expected.
Thank you very much.
The text was updated successfully, but these errors were encountered: