Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open links in a new tab/window #86

Open
ohadschn opened this issue Nov 26, 2017 · 1 comment
Open

Open links in a new tab/window #86

ohadschn opened this issue Nov 26, 2017 · 1 comment

Comments

@ohadschn
Copy link

ohadschn commented Nov 26, 2017

It is a good practice for media sites to open links in a new tab/windows (using target=“_blank”, preferably with rel="noopener" for better security and performance) as to not interrupt currently playing audio/video.

This is especially important as long as navigating out of the page incurs sign-out (#82).

@ohadschn
Copy link
Author

ohadschn commented Nov 26, 2017

Not sure about the direct track link BTW, because that would result in the track starting to play in SoundCloud concurrently. Maybe that one should be a regular link (that opens in the same tab).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants