crl: remove exports of untrusted::Input.
#83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't want to add `untrusted` to webpki's public API, but several fields of the `CertificateRevocationList` type did this accidentally. This commit makes the `untrusted::Input` fields crate-private and adds public methods that can return `&[u8]` versions of these fields for external usage. Along the way I also deleted the `CertificateRevocationLists` type - we didn't export that from `lib.rs`. I added this type before landing on the `CrlProvider` trait implemented in a separate branch. With that approach there's no need for a list-of-CRLs type.
Codecov Report
@@ Coverage Diff @@
## main #83 +/- ##
==========================================
- Coverage 95.68% 95.59% -0.10%
==========================================
Files 15 15
Lines 2900 2907 +7
==========================================
+ Hits 2775 2779 +4
- Misses 125 128 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
djc
approved these changes
Jun 15, 2023
ctz
approved these changes
Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't want to add
untrustedto webpki's public API, but several fields of theCertificateRevocationListtype did this accidentally when it was added in #44.This branch makes the
untrusted::Inputfields crate-private and adds public methods that can return&[u8]versions of these fields for external usage.Along the way I also deleted the
CertificateRevocationListstype - we didn't export that fromlib.rs. I added this type before landing on theCrlProvidertrait implemented in a separate branch. With that approach there's no need for a list-of-CRLs type. This also side-steps concerns about the best data structure to use: eachCrlProviderimplementation can choose their own approach.