Skip to content
This repository has been archived by the owner on Jun 24, 2024. It is now read-only.

Disable tokenizers-remote support for the library by default #436

Open
philpax opened this issue Oct 31, 2023 · 1 comment
Open

Disable tokenizers-remote support for the library by default #436

philpax opened this issue Oct 31, 2023 · 1 comment
Labels
issue:enhancement New feature or request meta:breaking-change Will require action on behalf of the developer

Comments

@philpax
Copy link
Collaborator

philpax commented Oct 31, 2023

While convenient, the tokenizers-remote feature means people will have OpenSSL dragged in unless they specify otherwise. It's probably a better default to have it disabled and let people opt in (e.g. the binary) if they want it.
@philpax philpax added issue:enhancement New feature or request meta:breaking-change Will require action on behalf of the developer labels Oct 31, 2023
@philpax philpax mentioned this issue Oct 31, 2023
Open
@pixelspark
Copy link
Contributor

Should gate this behind a feature flag imo 👍🏻

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
issue:enhancement New feature or request meta:breaking-change Will require action on behalf of the developer
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pixelspark @philpax