Skip to content

Commit e3b5bba

Browse files
committed
test: move test_check_rnage to mmap module
Switching the check_range() implementation from try_access() to get_slices() will mean that the test requires a working implementation of get_slice(), which MockRegion does not have. So instead have the test use the actual memory regions defined in the mmap module. Signed-off-by: Patrick Roy <[email protected]>
1 parent 64bcad5 commit e3b5bba

File tree

2 files changed

+23
-23
lines changed

2 files changed

+23
-23
lines changed

src/mmap/mod.rs

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -325,6 +325,29 @@ mod tests {
325325
}
326326
}
327327

328+
#[test]
329+
fn test_check_range() {
330+
let start_addr1 = GuestAddress(0);
331+
let start_addr2 = GuestAddress(0x800);
332+
let start_addr3 = GuestAddress(0xc00);
333+
let guest_mem = GuestMemoryMmap::from_ranges(&[
334+
(start_addr1, 0x400),
335+
(start_addr2, 0x400),
336+
(start_addr3, 0x400),
337+
])
338+
.unwrap();
339+
340+
assert!(guest_mem.check_range(start_addr1, 0x0));
341+
assert!(guest_mem.check_range(start_addr1, 0x200));
342+
assert!(guest_mem.check_range(start_addr1, 0x400));
343+
assert!(!guest_mem.check_range(start_addr1, 0xa00));
344+
assert!(guest_mem.check_range(start_addr2, 0x7ff));
345+
assert!(guest_mem.check_range(start_addr2, 0x800));
346+
assert!(!guest_mem.check_range(start_addr2, 0x801));
347+
assert!(!guest_mem.check_range(start_addr2, 0xc00));
348+
assert!(!guest_mem.check_range(start_addr1, usize::MAX));
349+
}
350+
328351
#[test]
329352
fn test_deref() {
330353
let f = TempFile::new().unwrap().into_file();

src/region.rs

Lines changed: 0 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -773,27 +773,4 @@ pub(crate) mod tests {
773773
Some(GuestAddress(0x400 - 1))
774774
);
775775
}
776-
777-
#[test]
778-
fn test_check_range() {
779-
let start_addr1 = GuestAddress(0);
780-
let start_addr2 = GuestAddress(0x800);
781-
let start_addr3 = GuestAddress(0xc00);
782-
let guest_mem = new_guest_memory_collection_from_regions(&[
783-
(start_addr1, 0x400),
784-
(start_addr2, 0x400),
785-
(start_addr3, 0x400),
786-
])
787-
.unwrap();
788-
789-
assert!(guest_mem.check_range(start_addr1, 0x0));
790-
assert!(guest_mem.check_range(start_addr1, 0x200));
791-
assert!(guest_mem.check_range(start_addr1, 0x400));
792-
assert!(!guest_mem.check_range(start_addr1, 0xa00));
793-
assert!(guest_mem.check_range(start_addr2, 0x7ff));
794-
assert!(guest_mem.check_range(start_addr2, 0x800));
795-
assert!(!guest_mem.check_range(start_addr2, 0x801));
796-
assert!(!guest_mem.check_range(start_addr2, 0xc00));
797-
assert!(!guest_mem.check_range(start_addr1, usize::MAX));
798-
}
799776
}

0 commit comments

Comments
 (0)