Fix cargo clippy

Signed-off-by: Gris Ge <[email protected]>

Author: cathay4t

examples/create_macvlan.rs

@@ -16,7 +16,7 @@ async fn main() -> Result<(), String> {
     }
     let link_name = &args[1];
     let mac: Option<Vec<u8>> = if args.len() == 3 {
-        let mac_address_arg = (&args[2]).to_string();
+        let mac_address_arg = args[2].to_string();
         let mac_address = MacAddr::from_str(mac_address_arg.as_str())
             .map_err(|e| format!("{e}"))?;
         Some(mac_address.as_bytes().into())

src/link/test.rs

@@ -32,7 +32,7 @@ fn create_get_delete_macvlan() {
     const MACVLAN_IFACE_NAME: &str = "mvlan1";
     const LOWER_DEVICE_IDX: u32 = 2;
     const MACVLAN_MODE: u32 = 4; // bridge
-    let mac_address = &vec![2u8, 0, 0, 0, 0, 1];
+    let mac_address = [2u8, 0, 0, 0, 0, 1];
 
     let rt = Runtime::new().unwrap();
     let handle = rt.block_on(_create_macvlan(
@@ -49,7 +49,7 @@ fn create_get_delete_macvlan() {
         rt.block_on(_get_iface(&mut handle, MACVLAN_IFACE_NAME.to_owned()));
     assert!(msg.is_ok());
     assert!(has_nla(
-        &msg.as_ref().unwrap(),
+        msg.as_ref().unwrap(),
         &LinkAttribute::LinkInfo(vec![
             LinkInfo::Kind(InfoKind::MacVlan),
             LinkInfo::Data(InfoData::MacVlan(vec![
@@ -62,15 +62,15 @@ fn create_get_delete_macvlan() {
         ])
     ));
     assert!(has_nla(
-        &msg.as_ref().unwrap(),
+        msg.as_ref().unwrap(),
         &LinkAttribute::IfName(MACVLAN_IFACE_NAME.to_string())
     ));
     assert!(has_nla(
-        &msg.as_ref().unwrap(),
+        msg.as_ref().unwrap(),
         &LinkAttribute::Link(LOWER_DEVICE_IDX)
     ));
     assert!(has_nla(
-        &msg.as_ref().unwrap(),
+        msg.as_ref().unwrap(),
         &LinkAttribute::Address(mac_address.to_vec())
     ));
 

src/ns.rs

@@ -10,7 +10,7 @@ use nix::{
     },
     unistd::{fork, ForkResult},
 };
-use std::{option::Option, os::fd::BorrowedFd, path::Path, process::exit};
+use std::{os::fd::BorrowedFd, path::Path, process::exit};
 
 // if "only" smol or smol+tokio were enabled, we use smol because
 // it doesn't require an active tokio runtime - just to be sure.

src/traffic_control/add_qdisc.rs

@@ -83,9 +83,7 @@ mod test {
 
     use super::*;
     use crate::{new_connection, NetworkNamespace, NETNS_PATH, SELF_NS_PATH};
-    use netlink_packet_route::{
-        link::LinkMessage, tc::TcAttribute, AddressFamily,
-    };
+    use netlink_packet_route::{link::LinkMessage, AddressFamily};
 
     const TEST_NS: &str = "netlink_test_qdisc_ns";
     const TEST_DUMMY: &str = "test_dummy";