update to netlink-packet-route 0.20

the main change is the switch to `bitflags` for manipulating fields
that contain flags.

Some integers have also been replaced by enums:

- `BondMode` replaced the raw `u8`
- `MacVlanMode` replaced the raw u32`
- `MacVtapMode` replaced the raw u32`

Author: little-dude

Cargo.toml

@@ -23,7 +23,7 @@ log = "0.4.8"
 thiserror = "1"
 netlink-sys = { version = "0.8" }
 netlink-packet-utils = { version = "0.5" }
-netlink-packet-route = { version = "0.19" }
+netlink-packet-route = { version = "0.20" }
 netlink-packet-core = { version = "0.7" }
 netlink-proto = { default-features = false, version = "0.11" }
 nix = { version = "0.27.1", default-features = false, features = ["fs", "mount", "sched", "signal"] }

examples/create_bond.rs

@@ -1,5 +1,6 @@
 // SPDX-License-Identifier: MIT
 
+use netlink_packet_route::link::BondMode;
 use rtnetlink::new_connection;
 use std::net::{Ipv4Addr, Ipv6Addr};
 
@@ -11,7 +12,7 @@ async fn main() -> Result<(), String> {
         .link()
         .add()
         .bond("my-bond".into())
-        .mode(1)
+        .mode(BondMode::ActiveBackup)
         .miimon(100)
         .updelay(100)
         .downdelay(100)

examples/create_macvlan.rs

@@ -5,7 +5,7 @@ use macaddr::MacAddr;
 use rtnetlink::{new_connection, Error, Handle};
 use std::{env, str::FromStr};
 
-use netlink_packet_route::link::LinkAttribute;
+use netlink_packet_route::link::{LinkAttribute, MacVlanMode};
 
 #[tokio::main]
 async fn main() -> Result<(), String> {
@@ -42,7 +42,7 @@ async fn create_macvlan(
         let mut request = handle.link().add().macvlan(
             "test_macvlan".into(),
             link.header.index,
-            4u32, // bridge mode
+            MacVlanMode::Bridge,
         );
         if let Some(mac) = mac_address {
             request

examples/create_macvtap.rs

@@ -1,6 +1,7 @@
 // SPDX-License-Identifier: MIT
 
 use futures::stream::TryStreamExt;
+use netlink_packet_route::link::MacVtapMode;
 use rtnetlink::{new_connection, Error, Handle};
 use std::env;
 
@@ -27,11 +28,10 @@ async fn create_macvtap(
 ) -> Result<(), Error> {
     let mut links = handle.link().get().match_name(veth_name.clone()).execute();
     if let Some(link) = links.try_next().await? {
-        // hard code mode: 4u32 i.e bridge mode
         let request = handle.link().add().macvtap(
             "test_macvtap".into(),
             link.header.index,
-            4u32,
+            MacVtapMode::Bridge,
         );
         request.execute().await?
     } else {

src/link/add.rs

@@ -13,9 +13,10 @@ use netlink_packet_core::{
 
 use netlink_packet_route::{
     link::{
-        InfoBond, InfoData, InfoKind, InfoMacVlan, InfoMacVtap, InfoVeth,
-        InfoVlan, InfoVrf, InfoVxlan, InfoXfrm, LinkAttribute, LinkFlag,
-        LinkInfo, LinkMessage, VlanQosMapping,
+        BondMode, InfoBond, InfoData, InfoKind, InfoMacVlan, InfoMacVtap,
+        InfoVeth, InfoVlan, InfoVrf, InfoVxlan, InfoXfrm, LinkAttribute,
+        LinkFlags, LinkInfo, LinkMessage, MacVlanMode, MacVtapMode,
+        VlanQosMapping,
     },
     RouteNetlinkMessage,
 };
@@ -45,7 +46,7 @@ impl BondAddRequest {
 
     /// Adds the `mode` attribute to the bond
     /// This is equivalent to `ip link add name NAME type bond mode MODE`.
-    pub fn mode(mut self, mode: u8) -> Self {
+    pub fn mode(mut self, mode: BondMode) -> Self {
         self.info_data.push(InfoBond::Mode(mode));
         self
     }
@@ -442,7 +443,7 @@ impl VxlanAddRequest {
 
     /// Adds the `learning` attribute to the VXLAN
     /// This is equivalent to `ip link add name NAME type vxlan id VNI
-    /// [no]learning`. [no]learning - specifies if unknown source link layer
+    /// \[no\]learning`. \[no\]learning - specifies if unknown source link layer
     /// addresses and IP addresses are entered into the VXLAN
     /// device forwarding database.
     pub fn learning(mut self, learning: bool) -> Self {
@@ -480,23 +481,23 @@ impl VxlanAddRequest {
 
     /// Adds the `proxy` attribute to the VXLAN
     /// This is equivalent to `ip link add name NAME type vxlan id VNI
-    /// [no]proxy`. [no]proxy - specifies ARP proxy is turned on.
+    /// [no]proxy`. \[no\]proxy - specifies ARP proxy is turned on.
     pub fn proxy(mut self, proxy: bool) -> Self {
         self.info_data.push(InfoVxlan::Proxy(proxy));
         self
     }
 
-    /// Adds the `rsc` attribute to the VXLAN
-    /// This is equivalent to `ip link add name NAME type vxlan id VNI [no]rsc`.
-    /// [no]rsc - specifies if route short circuit is turned on.
+    /// Adds the `rsc` attribute to the VXLAN This is equivalent to
+    /// `ip link add name NAME type vxlan id VNI [no]rsc`.
+    /// \[no\]rsc - specifies if route short circuit is turned on.
     pub fn rsc(mut self, rsc: bool) -> Self {
         self.info_data.push(InfoVxlan::Rsc(rsc));
         self
     }
 
     // Adds the `l2miss` attribute to the VXLAN
     /// This is equivalent to `ip link add name NAME type vxlan id VNI
-    /// [no]l2miss`. [no]l2miss - specifies if netlink LLADDR miss
+    /// [no]l2miss`. \[no\]l2miss - specifies if netlink LLADDR miss
     /// notifications are generated.
     pub fn l2miss(mut self, l2miss: bool) -> Self {
         self.info_data.push(InfoVxlan::L2Miss(l2miss));
@@ -505,8 +506,8 @@ impl VxlanAddRequest {
 
     // Adds the `l3miss` attribute to the VXLAN
     /// This is equivalent to `ip link add name NAME type vxlan id VNI
-    /// [no]l3miss`. [no]l3miss - specifies if netlink IP ADDR miss
-    /// notifications are generated.
+    /// [no]l3miss`. \[no\]l3miss - specifies if netlink IP ADDR
+    /// miss notifications are generated.
     pub fn l3miss(mut self, l3miss: bool) -> Self {
         self.info_data.push(InfoVxlan::L3Miss(l3miss));
         self
@@ -520,8 +521,8 @@ impl VxlanAddRequest {
 
     // Adds the `udp_csum` attribute to the VXLAN
     /// This is equivalent to `ip link add name NAME type vxlan id VNI
-    /// [no]udp_csum`. [no]udpcsum - specifies if UDP checksum is calculated
-    /// for transmitted packets over IPv4.
+    /// [no]udp_csum`. \[no\]udpcsum - specifies if UDP checksum is
+    /// calculated for transmitted packets over IPv4.
     pub fn udp_csum(mut self, udp_csum: bool) -> Self {
         self.info_data.push(InfoVxlan::UDPCsum(udp_csum));
         self
@@ -588,23 +589,22 @@ impl LinkAddRequest {
     ///
     /// Let's say we want to create a vlan interface on a link with id 6. By
     /// default, the [`vlan()`](#method.vlan) method would create a request
-    /// with the `LinkFlag::Up` link set, so that the interface is up after
+    /// with the `LinkFlags::Up` link set, so that the interface is up after
     /// creation. If we want to create a interface that is down by default we
     /// could do:
     ///
     /// ```rust,no_run
     /// use futures::Future;
-    /// use netlink_packet_route::link::LinkFlag;
+    /// use netlink_packet_route::link::LinkFlags;
     /// use rtnetlink::{Handle, new_connection};
     ///
     /// async fn run(handle: Handle) -> Result<(), String> {
     ///     let vlan_id = 100;
     ///     let link_id = 6;
     ///     let mut request = handle.link().add().vlan("my-vlan-itf".into(),
     ///         link_id, vlan_id);
-    ///     request.message_mut().header.flags.push(LinkFlag::Up);
-    ///     request.message_mut().header.change_mask.retain(
-    ///         |f| *f != LinkFlag::Up);
+    ///     request.message_mut().header.flags.remove(LinkFlags::Up);
+    ///     request.message_mut().header.change_mask.remove(LinkFlags::Up);
     ///     // send the request
     ///     request.execute().await.map_err(|e| format!("{}", e))
     /// }
@@ -628,8 +628,8 @@ impl LinkAddRequest {
 
         let mut peer = LinkMessage::default();
         // FIXME: we get a -107 (ENOTCONN) (???) when trying to set `name` up.
-        // peer.header.flags.push(LinkFlag::Up);
-        // peer.header.change_mask.push(LinkFlag::Up);
+        // peer.header.flags |= LinkFlags::Up;
+        // peer.header.change_mask |= LinkFlag::Up;
         peer.attributes.push(LinkAttribute::IfName(name));
         let link_info_data = InfoData::Veth(InfoVeth::Peer(peer));
         self.name(peer_name)
@@ -687,7 +687,7 @@ impl LinkAddRequest {
     /// flags from MACVLAN_MODE (netlink-packet-route/src/rtnl/constants.rs)
     ///   being: _PRIVATE, _VEPA, _BRIDGE, _PASSTHRU, _SOURCE, which can be
     /// *combined*.
-    pub fn macvlan(self, name: String, index: u32, mode: u32) -> Self {
+    pub fn macvlan(self, name: String, index: u32, mode: MacVlanMode) -> Self {
         self.name(name)
             .link_info(
                 InfoKind::MacVlan,
@@ -704,7 +704,7 @@ impl LinkAddRequest {
     /// flags from MACVTAP_MODE (netlink-packet-route/src/rtnl/constants.rs)
     ///   being: _PRIVATE, _VEPA, _BRIDGE, _PASSTHRU, _SOURCE, which can be
     /// *combined*.
-    pub fn macvtap(self, name: String, index: u32, mode: u32) -> Self {
+    pub fn macvtap(self, name: String, index: u32, mode: MacVtapMode) -> Self {
         self.name(name)
             .link_info(
                 InfoKind::MacVtap,
@@ -779,11 +779,7 @@ impl LinkAddRequest {
     /// This is equivalent to `ip link add NAME type wireguard`.
     pub fn wireguard(self, name: String) -> Self {
         let mut request = self.name(name).link_info(InfoKind::Wireguard, None);
-        request
-            .message_mut()
-            .header
-            .flags
-            .retain(|f| *f != LinkFlag::Up);
+        request.message_mut().header.flags.remove(LinkFlags::Up);
         request
     }
 
@@ -805,8 +801,8 @@ impl LinkAddRequest {
     }
 
     fn up(mut self) -> Self {
-        self.message.header.flags.push(LinkFlag::Up);
-        self.message.header.change_mask.push(LinkFlag::Up);
+        self.message.header.flags |= LinkFlags::Up;
+        self.message.header.change_mask |= LinkFlags::Up;
         self
     }
 

src/link/set.rs

@@ -7,7 +7,7 @@ use netlink_packet_core::{
     NetlinkMessage, NLM_F_ACK, NLM_F_CREATE, NLM_F_EXCL, NLM_F_REQUEST,
 };
 use netlink_packet_route::{
-    link::{LinkAttribute, LinkFlag, LinkMessage},
+    link::{LinkAttribute, LinkFlags, LinkMessage},
     RouteNetlinkMessage,
 };
 
@@ -105,43 +105,40 @@ impl LinkSetRequest {
     /// Set the link with the given index up (equivalent to `ip link set dev DEV
     /// up`)
     pub fn up(mut self) -> Self {
-        self.message.header.flags.push(LinkFlag::Up);
-        self.message.header.change_mask.push(LinkFlag::Up);
+        self.message.header.flags |= LinkFlags::Up;
+        self.message.header.change_mask |= LinkFlags::Up;
         self
     }
 
     /// Set the link with the given index down (equivalent to `ip link set dev
     /// DEV down`)
     pub fn down(mut self) -> Self {
-        self.message.header.flags.retain(|f| *f != LinkFlag::Up);
-        self.message.header.change_mask.push(LinkFlag::Up);
+        self.message.header.flags.remove(LinkFlags::Up);
+        self.message.header.change_mask |= LinkFlags::Up;
         self
     }
 
     /// Enable or disable promiscious mode of the link with the given index
     /// (equivalent to `ip link set dev DEV promisc on/off`)
     pub fn promiscuous(mut self, enable: bool) -> Self {
         if enable {
-            self.message.header.flags.push(LinkFlag::Promisc);
+            self.message.header.flags |= LinkFlags::Promisc;
         } else {
-            self.message
-                .header
-                .flags
-                .retain(|f| *f != LinkFlag::Promisc);
+            self.message.header.flags.remove(LinkFlags::Promisc);
         }
-        self.message.header.change_mask.push(LinkFlag::Promisc);
+        self.message.header.change_mask |= LinkFlags::Promisc;
         self
     }
 
     /// Enable or disable the ARP protocol of the link with the given index
     /// (equivalent to `ip link set dev DEV arp on/off`)
     pub fn arp(mut self, enable: bool) -> Self {
         if enable {
-            self.message.header.flags.retain(|f| *f != LinkFlag::Noarp);
+            self.message.header.flags.remove(LinkFlags::Noarp);
         } else {
-            self.message.header.flags.push(LinkFlag::Noarp);
+            self.message.header.flags |= LinkFlags::Noarp;
         }
-        self.message.header.change_mask.push(LinkFlag::Noarp);
+        self.message.header.change_mask |= LinkFlags::Noarp;
         self
     }
 

src/link/set_bond_port.rs

@@ -53,7 +53,7 @@ impl BondPortSetRequest {
         Ok(())
     }
 
-    /// Return a mutable reference to the Vec<InfoBondPort>
+    /// Return a mutable reference to the `Vec<InfoBondPort>`
     pub fn info_port_nlas_mut(&mut self) -> &mut Vec<InfoBondPort> {
         &mut self.port_nlas
     }

src/link/test.rs

@@ -3,7 +3,7 @@
 use futures::stream::TryStreamExt;
 use netlink_packet_route::link::{
     InfoData, InfoKind, InfoMacVlan, InfoVrf, LinkAttribute, LinkInfo,
-    LinkMessage,
+    LinkMessage, MacVlanMode,
 };
 use tokio::runtime::Runtime;
 
@@ -32,7 +32,7 @@ fn create_get_delete_wg() {
 fn create_get_delete_macvlan() {
     const MACVLAN_IFACE_NAME: &str = "mvlan1";
     const LOWER_DEVICE_IDX: u32 = 2;
-    const MACVLAN_MODE: u32 = 4; // bridge
+    const MACVLAN_MODE: MacVlanMode = MacVlanMode::Bridge;
     let mac_address = [2u8, 0, 0, 0, 0, 1];
 
     let rt = Runtime::new().unwrap();
@@ -142,7 +142,7 @@ async fn _del_iface(handle: &mut LinkHandle, index: u32) -> Result<(), Error> {
 async fn _create_macvlan(
     name: &String,
     lower_device_index: u32,
-    mode: u32,
+    mode: MacVlanMode,
     mac: Vec<u8>,
 ) -> Result<LinkHandle, Error> {
     let (conn, handle, _) = new_connection().unwrap();

src/neighbour/add.rs

@@ -8,7 +8,7 @@ use netlink_packet_core::{
 };
 use netlink_packet_route::{
     neighbour::{
-        NeighbourAddress, NeighbourAttribute, NeighbourFlag, NeighbourMessage,
+        NeighbourAddress, NeighbourAttribute, NeighbourFlags, NeighbourMessage,
         NeighbourState,
     },
     route::RouteType,
@@ -80,7 +80,7 @@ impl NeighbourAddRequest {
 
     /// Set flags for the neighbor cache entry.
     /// It should be a combination of `NTF_*` constants.
-    pub fn flags(mut self, flags: Vec<NeighbourFlag>) -> Self {
+    pub fn flags(mut self, flags: NeighbourFlags) -> Self {
         self.message.header.flags = flags;
         self
     }

src/neighbour/get.rs

@@ -9,7 +9,7 @@ use netlink_packet_core::{
     NetlinkMessage, NetlinkPayload, NLM_F_DUMP, NLM_F_REQUEST,
 };
 use netlink_packet_route::{
-    neighbour::{NeighbourFlag, NeighbourMessage},
+    neighbour::{NeighbourFlags, NeighbourMessage},
     RouteNetlinkMessage,
 };
 
@@ -29,7 +29,7 @@ impl NeighbourGetRequest {
     /// List neighbor proxies in the system (equivalent to: `ip neighbor show
     /// proxy`).
     pub fn proxies(mut self) -> Self {
-        self.message.header.flags.push(NeighbourFlag::Proxy);
+        self.message.header.flags |= NeighbourFlags::Proxy;
         self
     }