From f8ab2f4432e3af70d824b3dcf4da7bde3c1259d8 Mon Sep 17 00:00:00 2001 From: Ada Alakbarova Date: Wed, 15 Oct 2025 20:28:33 +0200 Subject: [PATCH 1/2] Run Clippy on CI --- .github/workflows/ci.yml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 92ed31a37..d14d47816 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -29,6 +29,11 @@ jobs: run: cargo test --workspace --all-targets - name: Check formatting run: cargo fmt --all --check + - name: Lint + run: | + # Install Clippy (not included in the `minimal` profile) + rustup component add clippy + cargo clippy --all --all-targets deploy: name: Deploy From a92cf2223cb159011bf99be969f1956edc040e91 Mon Sep 17 00:00:00 2001 From: Ada Alakbarova Date: Wed, 15 Oct 2025 20:28:56 +0200 Subject: [PATCH 2/2] Handle current warnings --- src/handlers.rs | 4 ---- src/rfcbot.rs | 2 -- 2 files changed, 6 deletions(-) diff --git a/src/handlers.rs b/src/handlers.rs index 022848638..670e1c258 100644 --- a/src/handlers.rs +++ b/src/handlers.rs @@ -69,10 +69,6 @@ pub struct Context { pub gha_logs: Arc>, } -#[expect( - clippy::collapsible_if, - reason = "we check the preconditions in the outer if, and handle errors inside" -)] pub async fn handle(ctx: &Context, host: &str, event: &Event) -> Vec { let config = config::get(&ctx.github, event.repo()).await; if let Err(e) = &config { diff --git a/src/rfcbot.rs b/src/rfcbot.rs index ca22993e0..3455b0579 100644 --- a/src/rfcbot.rs +++ b/src/rfcbot.rs @@ -35,7 +35,6 @@ pub struct Concern { pub reviewer: Reviewer, } #[derive(Serialize, Deserialize, Debug, Clone)] -#[expect(clippy::upper_case_acronyms, reason = "see reason on `FCP`")] pub struct FCPIssue { pub id: u32, pub number: u32, @@ -66,7 +65,6 @@ pub struct StatusComment { } #[derive(Serialize, Deserialize, Debug, Clone)] -#[expect(clippy::upper_case_acronyms, reason = "see reason on `FCP`")] pub struct FullFCP { pub fcp: FCP, pub reviews: Vec,