Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failures when GitHub team name does not match Rust team name #1889

Open
ehuss opened this issue Jan 24, 2025 · 0 comments
Open

Failures when GitHub team name does not match Rust team name #1889

ehuss opened this issue Jan 24, 2025 · 0 comments
Labels
A-notifications Area: the notifications manager

Comments

@ehuss
Copy link
Contributor

ehuss commented Jan 24, 2025

The notifications feature seems to fail when someone @'s a team where the team name does not match its GitHub team name.

This results in this error message:

2025-01-22T20:20:04.573850Z ERROR request{uuid=acf45229-ce61-4502-8867-7644ae50da21}: triagebot::handlers::notification: team ping (rust-lang/initiative-trait-system-refactor) failed to resolve to a known team

project-trait-system-refactor uses team-name to define a different GitHub team name: https://github.com/rust-lang/team/blob/bf46e5282e95a3057fd65d638a2f66e24efa55de/teams/project-trait-system-refactor.toml#L27

Might be good to audit if there are any other places which make the assumption that Rust team names match GitHub team names. I'm pretty sure r? assignment also makes this assumption.

@ehuss ehuss added the A-notifications Area: the notifications manager label Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-notifications Area: the notifications manager
Projects
None yet
Development

No branches or pull requests

1 participant