Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Teach rustbot about beta/stable PRs #1852

Closed
cuviper opened this issue Nov 1, 2024 · 2 comments
Closed

Teach rustbot about beta/stable PRs #1852

cuviper opened this issue Nov 1, 2024 · 2 comments

Comments

@cuviper
Copy link
Member

cuviper commented Nov 1, 2024

I wonder if we could improve messages like this on backports: rust-lang/rust#132468 (comment)

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

When the PR title starts with "[beta" or "[stable", we should instead warn if the PR is not targeting those specific branches.

(I left the strings open because some folks add a version in the brackets, like rust-lang/rust#132337)

@Urgau
Copy link
Member

Urgau commented Feb 6, 2025

Looking at the recent backport PRs in rust-lang/rust I think #1860 successfully addressed this issue.

Is my assessment right @cuviper?

@cuviper
Copy link
Member Author

cuviper commented Feb 6, 2025

Yeah, it's not harassing me any more, thanks! :)

@cuviper cuviper closed this as completed Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants