Skip to content

Provide a warning when using custom toolchains with extra components #4252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rami3l opened this issue Mar 14, 2025 · 2 comments
Open

Provide a warning when using custom toolchains with extra components #4252

rami3l opened this issue Mar 14, 2025 · 2 comments
Milestone

Comments

@rami3l
Copy link
Member

rami3l commented Mar 14, 2025

#4250 currently does not provide any custom toolchain validity check when provided with extra components, such as in the configuration below:

[toolchain]
channel = "ms-1.84.1"
targets = [
    "aarch64-pc-windows-msvc",
    "x86_64-pc-windows-msvc",
]

I think it will probably be worthwhile to add a warning clarifying that we are not doing any checks, as demonstrated in the new test.
#4250 (comment)

@rami3l rami3l added this to the 1.28.2 milestone Mar 14, 2025
@wesleywiser
Copy link
Member

Is the intent to provide a one-time warning, or one-time warning per toolchain or something else?

@rami3l
Copy link
Member Author

rami3l commented Mar 14, 2025

Is the intent to provide a one-time warning, or one-time warning per toolchain or something else?

@wesleywiser We definitely don't want to spam you with warnings, but that will depend on whether the detection of optional components is available in the first place, so I might tackle #4251 and then come back to this one.

@rami3l rami3l modified the milestones: 1.28.2, 1.28.3 Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants